<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10174">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix strncpy bugs in gsm/ipa.c<br><br>Change-Id: I423a24c55c9b9aa6fc8f501df94fe54c71ee2b2b<br>---<br>M src/gsm/ipa.c<br>1 file changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c</span><br><span>index 0c7aaad..aecde83 100644</span><br><span>--- a/src/gsm/ipa.c</span><br><span>+++ b/src/gsm/ipa.c</span><br><span>@@ -251,23 +251,23 @@</span><br><span>                       break;</span><br><span>               case IPAC_IDTAG_LOCATION1:</span><br><span>                   if (dev->location1)</span><br><span style="color: hsl(0, 100%, 40%);">-                          strncpy(str, dev->location1, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                              osmo_strlcpy(str, dev->location1, sizeof(str));</span><br><span>                   break;</span><br><span>               case IPAC_IDTAG_LOCATION2:</span><br><span>                   if (dev->location2)</span><br><span style="color: hsl(0, 100%, 40%);">-                          strncpy(str, dev->location2, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                              osmo_strlcpy(str, dev->location2, sizeof(str));</span><br><span>                   break;</span><br><span>               case IPAC_IDTAG_EQUIPVERS:</span><br><span>                   if (dev->equipvers)</span><br><span style="color: hsl(0, 100%, 40%);">-                          strncpy(str, dev->equipvers, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                              osmo_strlcpy(str, dev->equipvers, sizeof(str));</span><br><span>                   break;</span><br><span>               case IPAC_IDTAG_SWVERSION:</span><br><span>                   if (dev->swversion)</span><br><span style="color: hsl(0, 100%, 40%);">-                          strncpy(str, dev->swversion, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                              osmo_strlcpy(str, dev->swversion, sizeof(str));</span><br><span>                   break;</span><br><span>               case IPAC_IDTAG_UNITNAME:</span><br><span>                    if (dev->unit_name) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                snprintf(str, sizeof(str), dev->unit_name, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                                snprintf(str, sizeof(str), "%s", dev->unit_name);</span><br><span>                       } else {</span><br><span>                             snprintf(str, sizeof(str),</span><br><span>                                    "%02x-%02x-%02x-%02x-%02x-%02x",</span><br><span>@@ -278,7 +278,7 @@</span><br><span>                    break;</span><br><span>               case IPAC_IDTAG_SERNR:</span><br><span>                       if (dev->serno)</span><br><span style="color: hsl(0, 100%, 40%);">-                              strncpy(str, dev->serno, IPA_STRING_MAX);</span><br><span style="color: hsl(120, 100%, 40%);">+                          osmo_strlcpy(str, dev->serno, sizeof(str));</span><br><span>                       break;</span><br><span>               default:</span><br><span>                     LOGP(DLINP, LOGL_NOTICE,</span><br><span>@@ -286,7 +286,6 @@</span><br><span>                       msgb_free(msg);</span><br><span>                      return NULL;</span><br><span>                 }</span><br><span style="color: hsl(0, 100%, 40%);">-               str[IPA_STRING_MAX-1] = '\0';</span><br><span> </span><br><span>            LOGP(DLINP, LOGL_INFO, " tag %d: %s\n", ies_req[i], str);</span><br><span>          tag = msgb_put(msg, 3 + strlen(str) + 1);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10174">change 10174</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10174"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I423a24c55c9b9aa6fc8f501df94fe54c71ee2b2b </div>
<div style="display:none"> Gerrit-Change-Number: 10174 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>