<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10180">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: typos in log and comment<br><br>Change-Id: I2416d9a45e88f4317aa8e6644f5581a6f4f119c8<br>---<br>M src/libmsc/msc_mgcp.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/10180/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c</span><br><span>index e261e7a..f5bdeb7 100644</span><br><span>--- a/src/libmsc/msc_mgcp.c</span><br><span>+++ b/src/libmsc/msc_mgcp.c</span><br><span>@@ -315,8 +315,8 @@</span><br><span>         }</span><br><span> </span><br><span>        /* HACK: We put the connection in loopback mode at the beginnig to</span><br><span style="color: hsl(0, 100%, 40%);">-       * trick the NodeB into doing the IuUP negotiation with itsself.</span><br><span style="color: hsl(0, 100%, 40%);">-         * this is a hack we need because osmo-mgw does not support IuUP yet */</span><br><span style="color: hsl(120, 100%, 40%);">+        * trick the hNodeB into doing the IuUP negotiation with itself.</span><br><span style="color: hsl(120, 100%, 40%);">+       * This is a hack we need because osmo-mgw does not support IuUP yet, see OS#2459. */</span><br><span> #ifdef BUILD_IU</span><br><span>     if (conn->via_ran == RAN_UTRAN_IU)</span><br><span>                mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;</span><br><span>@@ -1044,19 +1044,19 @@</span><br><span>   OSMO_ASSERT(conn);</span><br><span> </span><br><span>       if (port == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid remote call leg port, assignmnet completion failed\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid remote call leg port, assignment completion failed\n",</span><br><span>                 vlr_subscr_name(conn->vsub));</span><br><span>                return -EINVAL;</span><br><span>      }</span><br><span>    if (!addr || strlen(addr) <= 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) missing remote call leg address, assignmnet completion failed\n",</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) missing remote call leg address, assignment completion failed\n",</span><br><span>                      vlr_subscr_name(conn->vsub));</span><br><span>                return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span>        mgcp_ctx = conn->rtp.mgcp_ctx;</span><br><span>    if (!mgcp_ctx) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid mgcp context, assignmnet completion failed.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid mgcp context, assignment completion failed.\n",</span><br><span>                vlr_subscr_name(conn->vsub));</span><br><span>                return -EINVAL;</span><br><span>      }</span><br><span>@@ -1066,7 +1066,7 @@</span><br><span>    conn->rtp.remote_port_ran = port;</span><br><span>         osmo_strlcpy(conn->rtp.remote_addr_ran, addr, sizeof(conn->rtp.remote_addr_ran));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     LOGP(DMGCP, LOGL_DEBUG, "(subscriber:%s) assignmnet completed, rtp %s:%d.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGP(DMGCP, LOGL_DEBUG, "(subscriber:%s) assignment completed, rtp %s:%d.\n",</span><br><span>           vlr_subscr_name(conn->vsub), conn->rtp.remote_addr_ran, port);</span><br><span> </span><br><span>        /* Note: We only dispatch the event if we are really waiting for the</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10180">change 10180</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10180"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2416d9a45e88f4317aa8e6644f5581a6f4f119c8 </div>
<div style="display:none"> Gerrit-Change-Number: 10180 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>