<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10176">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: osmo-sim-test.c: use memcpy instead of strncpy<br><br>gcc 8.1.0 complains that the terminating \0 is not copied by strncpy, while<br>this code intends to do exactly that. Use memcpy instead.<br><br>Change-Id: I8d66fa22502c04d11ae153b9856d7e54f3492dd6<br>---<br>M utils/osmo-sim-test.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/10176/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c</span><br><span>index ea24120..5588294 100644</span><br><span>--- a/utils/osmo-sim-test.c</span><br><span>+++ b/utils/osmo-sim-test.c</span><br><span>@@ -74,7 +74,8 @@</span><br><span>         msg = osim_new_apdumsg(0x00, 0x20, 0x00, pin_nr, 8, 0);</span><br><span>      pindst = (char *) msgb_put(msg, 8);</span><br><span>  memset(pindst, 0xFF, 8);</span><br><span style="color: hsl(0, 100%, 40%);">-        strncpy(pindst, pin, strlen(pin));</span><br><span style="color: hsl(120, 100%, 40%);">+    /* Do not copy the terminating \0 */</span><br><span style="color: hsl(120, 100%, 40%);">+  memcpy(pindst, pin, strlen(pin));</span><br><span> </span><br><span>        return osim_transceive_apdu(st, msg);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10176">change 10176</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10176"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8d66fa22502c04d11ae153b9856d7e54f3492dd6 </div>
<div style="display:none"> Gerrit-Change-Number: 10176 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>