<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10135">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging_vty: Simplify code in config_write_log_single<br><br>Since we ignore "logging level CAT everything" in logging_level_cmd, we<br>can never run into the case in which we have loglevel==EVERYTHING, so we<br>can simplify this code and make it esier for later removal of everything<br>keyword.<br><br>Change-Id: I4e76c65a11cc22616c6dfc632435617ebb861c03<br>---<br>M src/vty/logging_vty.c<br>1 file changed, 1 insertion(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c</span><br><span>index 8151fda..1194914 100644</span><br><span>--- a/src/vty/logging_vty.c</span><br><span>+++ b/src/vty/logging_vty.c</span><br><span>@@ -814,15 +814,9 @@</span><br><span>              /* stupid old osmo logging API uses uppercase strings... */</span><br><span>          osmo_str2lower(cat_lower, osmo_log_info->cat[i].name+1);</span><br><span>          osmo_str2lower(level_lower, log_level_str(cat->loglevel));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-           if (strcmp(level_lower, "everything") != 0) /* FIXME: remove this check once 'everything' is phased out */</span><br><span style="color: hsl(0, 100%, 40%);">-                    vty_out(vty, "  logging level %s %s%s", cat_lower, level_lower, VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-         else</span><br><span style="color: hsl(0, 100%, 40%);">-                    LOGP(DLSTATS, LOGL_ERROR, "logging level everything is deprecated and should not be used\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               vty_out(vty, "  logging level %s %s%s", cat_lower, level_lower, VTY_NEWLINE);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* FIXME: levels */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  return 1;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10135">change 10135</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10135"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4e76c65a11cc22616c6dfc632435617ebb861c03 </div>
<div style="display:none"> Gerrit-Change-Number: 10135 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>