<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10123">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">I2C: add wait time after write to let EEPROM write<br><br>The Atmel AT24C02 defines a maximum tWR waiting time after a byte<br>write of 5 ms before a next write.<br>Enforcing this wait time also fixed the failed verification in qmod,<br>where it was reading 0xffff instead of the written value.<br><br>Change-Id: I42c90b8d0329e425f275067e87d584212a43a90b<br>---<br>M firmware/libboard/qmod/source/i2c.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/qmod/source/i2c.c b/firmware/libboard/qmod/source/i2c.c</span><br><span>index 06c7565..a708704 100644</span><br><span>--- a/firmware/libboard/qmod/source/i2c.c</span><br><span>+++ b/firmware/libboard/qmod/source/i2c.c</span><br><span>@@ -185,6 +185,8 @@</span><br><span>    nack = i2c_write_byte(false, true, byte);</span><br><span>    if (nack)</span><br><span>            goto out_stop;</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Wait tWR time to ensure EEPROM is writing correctly (tWR = 5 ms for AT24C02) */</span><br><span style="color: hsl(120, 100%, 40%);">+    mdelay(5);</span><br><span> </span><br><span> out_stop:</span><br><span>  i2c_stop_cond();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10123">change 10123</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10123"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I42c90b8d0329e425f275067e87d584212a43a90b </div>
<div style="display:none"> Gerrit-Change-Number: 10123 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>