<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10124">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">I2C: return error after failed write<br><br>The previous mechanism of retrying a failed write could become a<br>infinite blocking loop (until watchdog tiemout).<br><br>Also the array size is used to know how much data to write and verify<br>instead of a constant.<br><br>Change-Id: I8d2d090c5f4d1195f4c7eb29b3958a7bb05f56ec<br>---<br>M firmware/libboard/qmod/source/board_qmod.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/24/10124/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>index 7ae1978..47a4cb6 100644</span><br><span>--- a/firmware/libboard/qmod/source/board_qmod.c</span><br><span>+++ b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>@@ -70,8 +70,6 @@</span><br><span> #include "i2c.h"</span><br><span> static int write_hub_eeprom(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    const unsigned int __eeprom_bin_len = 256;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   int i;</span><br><span> </span><br><span>   /* wait */</span><br><span>@@ -79,16 +77,18 @@</span><br><span> </span><br><span>         TRACE_INFO("Writing EEPROM...\n\r");</span><br><span>       /* write the EEPROM once */</span><br><span style="color: hsl(0, 100%, 40%);">-     for (i = 0; i < 256; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+        for (i = 0; i < ARRAY_SIZE(__eeprom_bin); i++) {</span><br><span>          int rc = eeprom_write_byte(0x50, i, __eeprom_bin[i]);</span><br><span style="color: hsl(0, 100%, 40%);">-           /* if the result was negative, repeat that write */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (rc < 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                  i--;</span><br><span style="color: hsl(120, 100%, 40%);">+          if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      TRACE_ERROR("Writing EEPROM failed at byte %u: 0x%02x\n\r",</span><br><span style="color: hsl(120, 100%, 40%);">+                         i, __eeprom_bin[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+                  return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>    }</span><br><span> </span><br><span>        /* then pursue re-reading it again and again */</span><br><span>      TRACE_INFO("Verifying EEPROM...\n\r");</span><br><span style="color: hsl(0, 100%, 40%);">-        for (i = 0; i < 256; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+        for (i = 0; i < ARRAY_SIZE(__eeprom_bin); i++) {</span><br><span>          int byte = eeprom_read_byte(0x50, i);</span><br><span>                TRACE_INFO("0x%02x: %02x\n\r", i, byte);</span><br><span>           if (byte != __eeprom_bin[i])</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10124">change 10124</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10124"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8d2d090c5f4d1195f4c7eb29b3958a7bb05f56ec </div>
<div style="display:none"> Gerrit-Change-Number: 10124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>