<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10131">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">prevent heap overflow in tch_fr_disassemble()<br><br>Ensure that sched_prim_init() allocates at least GSM_BURST_PL_LEN<br>bytes of payload buffer. An incomplete packet received could lead<br>to short buffer allocation and cause a crash in libosmocore.<br><br>Change-Id: I3ae3a1a14d131de256b48d645130df737e9b5f26<br>Related: OS#3415<br>---<br>M src/host/trxcon/sched_prim.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/31/10131/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c</span><br><span>index 2ee06d7..169a906 100644</span><br><span>--- a/src/host/trxcon/sched_prim.c</span><br><span>+++ b/src/host/trxcon/sched_prim.c</span><br><span>@@ -68,7 +68,7 @@</span><br><span> </span><br><span>       /* How much memory do we need? */</span><br><span>    len  = sizeof(struct trx_ts_prim); /* Primitive header */</span><br><span style="color: hsl(0, 100%, 40%);">-       len += pl_len; /* Requested payload size */</span><br><span style="color: hsl(120, 100%, 40%);">+   len += pl_len < GSM_BURST_PL_LEN ? GSM_BURST_PL_LEN : pl_len; /* Requested payload size */</span><br><span> </span><br><span>    /* Allocate a new primitive */</span><br><span>       new_prim = talloc_zero_size(trx, len);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10131">change 10131</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10131"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3ae3a1a14d131de256b48d645130df737e9b5f26 </div>
<div style="display:none"> Gerrit-Change-Number: 10131 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>