<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10059">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">various logging: fix missing/extra newlines<br><br>Change-Id: Id2619d0d45eb2686246c03643b4a578392a54cfe<br>---<br>M src/libfilter/bsc_msg_acc.c<br>M src/osmo-bsc/abis_nm.c<br>M src/osmo-bsc/abis_rsl.c<br>M src/osmo-bsc/handover_decision_2.c<br>M src/osmo-bsc/system_information.c<br>5 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libfilter/bsc_msg_acc.c b/src/libfilter/bsc_msg_acc.c</span><br><span>index 46077b3..de6c4d9 100644</span><br><span>--- a/src/libfilter/bsc_msg_acc.c</span><br><span>+++ b/src/libfilter/bsc_msg_acc.c</span><br><span>@@ -96,7 +96,7 @@</span><br><span> </span><br><span> lst = talloc_zero(ctx, struct bsc_msg_acc_lst);</span><br><span> if (!lst) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list\n");</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index cb1cc56..d056bc4 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -1214,11 +1214,11 @@</span><br><span> </span><br><span> /* go back to the start as we checked the whole filesize.. */</span><br><span> lseek(sw->fd, 0l, SEEK_SET);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DNM, LOGL_NOTICE, "The ipaccess SDP header is not fully understood.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "There might be checksums in the file that are not\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "verified and incomplete firmware might be flashed.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "There is absolutely no WARRANTY that flashing will\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "work.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DNM, LOGL_NOTICE, "The ipaccess SDP header is not fully understood."</span><br><span style="color: hsl(120, 100%, 40%);">+ " There might be checksums in the file that are not"</span><br><span style="color: hsl(120, 100%, 40%);">+ " verified and incomplete firmware might be flashed."</span><br><span style="color: hsl(120, 100%, 40%);">+ " There is absolutely no WARRANTY that flashing will"</span><br><span style="color: hsl(120, 100%, 40%);">+ " work.\n");</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index ab3658d..bcc56bc 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -2351,7 +2351,7 @@</span><br><span> break;</span><br><span> }</span><br><span> LOGP(DRSL, LOGL_ERROR, "Cannot determine ip.access rtp payload type for "</span><br><span style="color: hsl(0, 100%, 40%);">- "tch_mode == 0x%02x\n & lchan_type == %d",</span><br><span style="color: hsl(120, 100%, 40%);">+ "tch_mode == 0x%02x & lchan_type == %d\n",</span><br><span> lchan->tch_mode, lchan->type);</span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index e514b6c..826dcaa 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -1680,7 +1680,7 @@</span><br><span> struct gsm_subscriber_connection *conn = ho->old_lchan->conn;</span><br><span> </span><br><span> if (!conn) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPHO(ho, LOGL_ERROR, "HO failure, but no conn");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPHO(ho, LOGL_ERROR, "HO failure, but no conn\n");</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c</span><br><span>index d99153f..f810f52 100644</span><br><span>--- a/src/osmo-bsc/system_information.c</span><br><span>+++ b/src/osmo-bsc/system_information.c</span><br><span>@@ -556,7 +556,7 @@</span><br><span> return 0;</span><br><span> </span><br><span> LOGP(DRR, LOGL_ERROR, "min_arfcn=%u, max_arfcn=%u, arfcns=%d "</span><br><span style="color: hsl(0, 100%, 40%);">- "can not generate ARFCN list", min, max, arfcns);</span><br><span style="color: hsl(120, 100%, 40%);">+ "can not generate ARFCN list\n", min, max, arfcns);</span><br><span> return -EINVAL;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10059">change 10059</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10059"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id2619d0d45eb2686246c03643b4a578392a54cfe </div>
<div style="display:none"> Gerrit-Change-Number: 10059 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>