<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10057">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ho cfg: fix unit strings<br><br>Change-Id: Ie98a68de207aea69befd24af3f302b6ef9e6f8e4<br>---<br>M include/osmocom/bsc/handover_cfg.h<br>M tests/handover_cfg.vty<br>2 files changed, 21 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/handover_cfg.h b/include/osmocom/bsc/handover_cfg.h</span><br><span>index 2321fcf..865fab9 100644</span><br><span>--- a/include/osmocom/bsc/handover_cfg.h</span><br><span>+++ b/include/osmocom/bsc/handover_cfg.h</span><br><span>@@ -126,8 +126,8 @@</span><br><span> "handover1 ", "power budget hysteresis", "<0-999>", atoi, "%u", as_is, \</span><br><span> HO_CFG_STR_HANDOVER1 \</span><br><span> HO_CFG_STR_POWER_BUDGET \</span><br><span style="color: hsl(0, 100%, 40%);">- "How many dBm stronger must a neighbor be to become a HO candidate\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "Neighbor's strength difference in dBm\n") \</span><br><span style="color: hsl(120, 100%, 40%);">+ "How many dB stronger must a neighbor be to become a HO candidate\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "Neighbor's strength difference in dB\n") \</span><br><span> \</span><br><span> HO_CFG_ONE_MEMBER(unsigned int, hodec1_max_distance, 9999, \</span><br><span> "handover1 ", "maximum distance" , "<0-9999>", atoi, "%u", as_is, \</span><br><span>@@ -172,8 +172,8 @@</span><br><span> "handover2 ", "power budget hysteresis", "<0-999>", atoi, "%u", as_is, \</span><br><span> HO_CFG_STR_HANDOVER2 \</span><br><span> HO_CFG_STR_POWER_BUDGET \</span><br><span style="color: hsl(0, 100%, 40%);">- "How many dBm stronger must a neighbor be to become a HO candidate\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "Neighbor's strength difference in dBm\n") \</span><br><span style="color: hsl(120, 100%, 40%);">+ "How many dB stronger must a neighbor be to become a HO candidate\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ "Neighbor's strength difference in dB\n") \</span><br><span> \</span><br><span> HO_CFG_ONE_MEMBER(unsigned int, hodec2_max_distance, 9999, \</span><br><span> "handover2 ", "maximum distance" , "<0-9999>", atoi, "%u", as_is, \</span><br><span>@@ -208,21 +208,21 @@</span><br><span> HO_CFG_STR_HANDOVER2 \</span><br><span> HO_CFG_STR_MIN \</span><br><span> "How bad may RxQual of an MS become before triggering HO\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "minimum RxQual (dBm)\n") \</span><br><span style="color: hsl(120, 100%, 40%);">+ "minimum RxQual\n") \</span><br><span> \</span><br><span> HO_CFG_ONE_MEMBER(int, hodec2_afs_bias_rxlev, 0, \</span><br><span> "handover2 ", "afs-bias rxlev", "<0-20>", atoi, "%d", as_is, \</span><br><span> HO_CFG_STR_HANDOVER2 \</span><br><span> HO_CFG_STR_AFS_BIAS \</span><br><span> "RxLev improvement bias for AFS over other codecs\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "Virtual RxLev improvement (dBm)\n") \</span><br><span style="color: hsl(120, 100%, 40%);">+ "Virtual RxLev improvement (dB)\n") \</span><br><span> \</span><br><span> HO_CFG_ONE_MEMBER(int, hodec2_afs_bias_rxqual, 0, \</span><br><span> "handover2 ", "afs-bias rxqual", "<0-7>", atoi, "%d", as_is, \</span><br><span> HO_CFG_STR_HANDOVER2 \</span><br><span> HO_CFG_STR_AFS_BIAS \</span><br><span> "RxQual improvement bias for AFS over other codecs\n" \</span><br><span style="color: hsl(0, 100%, 40%);">- "Virtual RxQual improvement (dBm)\n") \</span><br><span style="color: hsl(120, 100%, 40%);">+ "Virtual RxQual improvement\n") \</span><br><span> \</span><br><span> HO_CFG_ONE_MEMBER(int, hodec2_tchf_min_slots, 0, \</span><br><span> "handover2 ", "min-free-slots tch/f", "<0-9999>", atoi, "%d", as_is, \</span><br><span>diff --git a/tests/handover_cfg.vty b/tests/handover_cfg.vty</span><br><span>index 3ad44d8..119eaf5 100644</span><br><span>--- a/tests/handover_cfg.vty</span><br><span>+++ b/tests/handover_cfg.vty</span><br><span>@@ -264,14 +264,14 @@</span><br><span> </span><br><span> OsmoBSC(config-net)# handover1 power budget ?</span><br><span> interval How often to check for a better cell (SACCH frames)</span><br><span style="color: hsl(0, 100%, 40%);">- hysteresis How many dBm stronger must a neighbor be to become a HO candidate</span><br><span style="color: hsl(120, 100%, 40%);">+ hysteresis How many dB stronger must a neighbor be to become a HO candidate</span><br><span> </span><br><span> OsmoBSC(config-net)# handover1 power budget interval ?</span><br><span> <1-99> Check for stronger neighbor every N number of SACCH frames</span><br><span> default Use default (6), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover1 power budget hysteresis ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-999> Neighbor's strength difference in dBm</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-999> Neighbor's strength difference in dB</span><br><span> default Use default (3), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover1 maximum ?</span><br><span>@@ -312,14 +312,14 @@</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 power budget ?</span><br><span> interval How often to check for a better cell (SACCH frames)</span><br><span style="color: hsl(0, 100%, 40%);">- hysteresis How many dBm stronger must a neighbor be to become a HO candidate</span><br><span style="color: hsl(120, 100%, 40%);">+ hysteresis How many dB stronger must a neighbor be to become a HO candidate</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 power budget interval ?</span><br><span> <1-99> Check for stronger neighbor every N number of SACCH frames</span><br><span> default Use default (6), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 power budget hysteresis ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-999> Neighbor's strength difference in dBm</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-999> Neighbor's strength difference in dB</span><br><span> default Use default (3), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 maximum ?</span><br><span>@@ -348,7 +348,7 @@</span><br><span> default Use default (-100), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 min rxqual ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-7> minimum RxQual (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-7> minimum RxQual</span><br><span> default Use default (5), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 afs-bias ?</span><br><span>@@ -356,11 +356,11 @@</span><br><span> rxqual RxQual improvement bias for AFS over other codecs</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 afs-bias rxlev ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-20> Virtual RxLev improvement (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-20> Virtual RxLev improvement (dB)</span><br><span> default Use default (0), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 afs-bias rxqual ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-7> Virtual RxQual improvement (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-7> Virtual RxQual improvement</span><br><span> default Use default (0), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net)# handover2 min-free-slots ?</span><br><span>@@ -482,14 +482,14 @@</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover1 power budget ?</span><br><span> interval How often to check for a better cell (SACCH frames)</span><br><span style="color: hsl(0, 100%, 40%);">- hysteresis How many dBm stronger must a neighbor be to become a HO candidate</span><br><span style="color: hsl(120, 100%, 40%);">+ hysteresis How many dB stronger must a neighbor be to become a HO candidate</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover1 power budget interval ?</span><br><span> <1-99> Check for stronger neighbor every N number of SACCH frames</span><br><span> default Use default (6), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover1 power budget hysteresis ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-999> Neighbor's strength difference in dBm</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-999> Neighbor's strength difference in dB</span><br><span> default Use default (3), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover1 maximum ?</span><br><span>@@ -530,14 +530,14 @@</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 power budget ?</span><br><span> interval How often to check for a better cell (SACCH frames)</span><br><span style="color: hsl(0, 100%, 40%);">- hysteresis How many dBm stronger must a neighbor be to become a HO candidate</span><br><span style="color: hsl(120, 100%, 40%);">+ hysteresis How many dB stronger must a neighbor be to become a HO candidate</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 power budget interval ?</span><br><span> <1-99> Check for stronger neighbor every N number of SACCH frames</span><br><span> default Use default (6), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 power budget hysteresis ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-999> Neighbor's strength difference in dBm</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-999> Neighbor's strength difference in dB</span><br><span> default Use default (3), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 maximum ?</span><br><span>@@ -566,7 +566,7 @@</span><br><span> default Use default (-100), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 min rxqual ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-7> minimum RxQual (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-7> minimum RxQual</span><br><span> default Use default (5), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 afs-bias ?</span><br><span>@@ -574,11 +574,11 @@</span><br><span> rxqual RxQual improvement bias for AFS over other codecs</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 afs-bias rxlev ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-20> Virtual RxLev improvement (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-20> Virtual RxLev improvement (dB)</span><br><span> default Use default (0), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 afs-bias rxqual ?</span><br><span style="color: hsl(0, 100%, 40%);">- <0-7> Virtual RxQual improvement (dBm)</span><br><span style="color: hsl(120, 100%, 40%);">+ <0-7> Virtual RxQual improvement</span><br><span> default Use default (0), remove explicit setting on this node</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# handover2 min-free-slots ?</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10057">change 10057</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10057"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie98a68de207aea69befd24af3f302b6ef9e6f8e4 </div>
<div style="display:none"> Gerrit-Change-Number: 10057 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>