<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10056">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix handover start: dealloc ho if event not permitted<br><br>Before this, a handover request in a conn state that disallows it would leave a<br>lingering handover state in the conn, also thwarting any future handover<br>attempts. (It would be deallocated on conn teardown, so no memleak.)<br><br>Change-Id: I839a05495ae93c5dbbd1616efa2469e5b1990a61<br>---<br>M src/osmo-bsc/handover_logic.c<br>1 file changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_logic.c b/src/osmo-bsc/handover_logic.c</span><br><span>index 960bf69..064615c 100644</span><br><span>--- a/src/osmo-bsc/handover_logic.c</span><br><span>+++ b/src/osmo-bsc/handover_logic.c</span><br><span>@@ -82,6 +82,7 @@</span><br><span> int bsc_handover_start(enum hodec_id from_hodec_id, struct gsm_lchan *old_lchan, struct gsm_bts *new_bts,</span><br><span>                   enum gsm_chan_t new_lchan_type)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+   int rc;</span><br><span>      struct gsm_subscriber_connection *conn;</span><br><span>      struct bsc_handover *ho;</span><br><span>     static uint8_t ho_ref = 0;</span><br><span>@@ -132,7 +133,14 @@</span><br><span>           gsm_lchant_name(new_lchan_type),</span><br><span>             do_assignment ? "Assignment" : "Handover");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      return osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HO_START, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+  rc = osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HO_START, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPHO(ho, LOGL_ERROR, "Failed to trigger handover, conn state does not allow it\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               conn->ho = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+           talloc_free(ho);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+     return rc;</span><br><span> }</span><br><span> </span><br><span> /*! Start actual handover. Call bsc_handover_start() instead; The only legal caller is the GSCON FSM in</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10056">change 10056</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10056"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I839a05495ae93c5dbbd1616efa2469e5b1990a61 </div>
<div style="display:none"> Gerrit-Change-Number: 10056 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>