<p>Stefan Sperling <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10060">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix TC_pdp4_act_deact_with_separate_dns<br><br>Do not delete the PDP context too early, and look for the second DNS<br>server in the correct place (2nd match on IPCP protocol, not 1st).<br><br>Update a comment which talks about a bug which has been fixed.<br><br>Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf<br>Related: OS#3319<br>Related: OS#3381<br>---<br>M ggsn_tests/GGSN_Tests.ttcn<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>index 6ae205f..3c99fd9 100644</span><br><span>--- a/ggsn_tests/GGSN_Tests.ttcn</span><br><span>+++ b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>@@ -1017,11 +1017,10 @@</span><br><span>                if (not match(pco_neg_dns, pco_neg_dns_expected)) {</span><br><span>                  setverdict(fail, "Primary DNS IPv4 PCO option not found");</span><br><span>                 }</span><br><span style="color: hsl(0, 100%, 40%);">-               f_pdp_ctx_del(ctx, '1'B);</span><br><span> </span><br><span>                /* Check if secondary DNS is contained */</span><br><span style="color: hsl(0, 100%, 40%);">-               /* Note: this check fill fail due to a bug in osmo-ggsn, see also OS#3381 */</span><br><span style="color: hsl(0, 100%, 40%);">-            pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+          /* This used to fail due to a bug in osmo-ggsn, see OS#3381 */</span><br><span style="color: hsl(120, 100%, 40%);">+                pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 2);</span><br><span>                 pco_neg_dns_expected := '0200000A8306'O & ggsn_ip4_dns2</span><br><span>          if (not match(pco_neg_dns, pco_neg_dns_expected)) {</span><br><span>                  setverdict(fail, "Secondary DNS IPv4 PCO option not found");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10060">change 10060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf </div>
<div style="display:none"> Gerrit-Change-Number: 10060 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>