<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10037">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Add test to verify GPRS ctx deact caused by GTP ErrorInd<br><br>Change-Id: I40e877f4126e62a731b071ae1d6d855fed210433<br>---<br>M sgsn/SGSN_Tests.ttcn<br>M sgsn/expected-results.xml<br>2 files changed, 33 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/10037/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index d76c182..78086af 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -959,19 +959,22 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_pdp_ctx_deact_mt(inout PdpActPars apars, OCT1 cause) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_pdp_ctx_deact_mt(inout PdpActPars apars, boolean error_ind := false) runs on BSSGP_ConnHdlr {</span><br><span>         var Gtp1cUnitdata g_ud;</span><br><span>      var integer seq_nr := 23;</span><br><span>    var GtpPeer peer := valueof(ts_GtpPeerC(apars.sgsn_ip_c));</span><br><span> </span><br><span>       BSSGP.clear;</span><br><span style="color: hsl(0, 100%, 40%);">-    GTP.send(ts_GTPC_DeletePDP(peer, seq_nr, apars.sgsn_tei_c, apars.nsapi, '1'B));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- interleave {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (error_ind) {</span><br><span style="color: hsl(120, 100%, 40%);">+              GTP.send(ts_GTPU_ErrorIndication(peer, 0 /* seq */, apars.ggsn_tei_u, apars.ggsn_ip_u));</span><br><span style="color: hsl(120, 100%, 40%);">+      } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              GTP.send(ts_GTPC_DeletePDP(peer, seq_nr, apars.sgsn_tei_c, apars.nsapi, '1'B));</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     alt {</span><br><span>        [] BSSGP.receive(tr_BD_L3_MT(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true))) {</span><br><span>          BSSGP.send(ts_SM_DEACT_PDP_ACCEPT_MO(apars.tid));</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] GTP.receive(tr_GTPC_MsgType(?, deletePDPContextResponse, apars.ggsn_tei_c)) { }</span><br><span style="color: hsl(120, 100%, 40%);">+    [not error_ind] GTP.receive(tr_GTPC_MsgType(?, deletePDPContextResponse, apars.ggsn_tei_c)) { }</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span>@@ -1241,7 +1244,7 @@</span><br><span>   f_gtpu_xceive_mt(apars, f_rnd_octstring(100));</span><br><span>       f_gtpu_xceive_mo(apars, f_rnd_octstring(200));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      f_pdp_ctx_deact_mt(apars, '00'O);</span><br><span style="color: hsl(120, 100%, 40%);">+     f_pdp_ctx_deact_mt(apars, false);</span><br><span> }</span><br><span> testcase TC_attach_pdp_act_user_deact_mt() runs on test_CT {</span><br><span>       var BSSGP_ConnHdlr vc_conn;</span><br><span>@@ -1411,6 +1414,27 @@</span><br><span>         }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* ATTACH + PDP CTX ACT + user plane traffic + ERROR IND in MT direction */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_attach_pdp_act_user_error_ind_ggsn(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+     var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+    f_TC_attach(id);</span><br><span style="color: hsl(120, 100%, 40%);">+      /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+       f_pdp_ctx_act(apars);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then transceive a downlink PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+  f_gtpu_xceive_mo(apars, f_rnd_octstring(200));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      /* Send Error indication as response from upload PDU and expect deact towards MS */</span><br><span style="color: hsl(120, 100%, 40%);">+   f_pdp_ctx_deact_mt(apars, true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_attach_pdp_act_user_error_ind_ggsn() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+       var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+   f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+     vc_conn := f_start_handler(refers(f_TC_attach_pdp_act_user_error_ind_ggsn), testcasename(), g_gb[0], 26);</span><br><span style="color: hsl(120, 100%, 40%);">+     vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_hlr_location_cancel_request_update() runs on test_CT {</span><br><span>     /* MS <-> SGSN: GMM Attach</span><br><span>      * HLR -> SGSN: Cancel Location Request</span><br><span>@@ -1762,6 +1786,7 @@</span><br><span>   execute( TC_attach_restart_ctr_echo() );</span><br><span>     execute( TC_attach_restart_ctr_create() );</span><br><span>   execute( TC_attach_pdp_act_deact_mt_t3395_expire() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_attach_pdp_act_user_error_ind_ggsn() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml</span><br><span>index 5b756cd..bb38a7c 100644</span><br><span>--- a/sgsn/expected-results.xml</span><br><span>+++ b/sgsn/expected-results.xml</span><br><span>@@ -1,5 +1,5 @@</span><br><span> <?xml version="1.0"?></span><br><span style="color: hsl(0, 100%, 40%);">-<testsuite name='Titan' tests='29' failures='4' errors='3' skipped='0' inconc='0' time='MASKED'></span><br><span style="color: hsl(120, 100%, 40%);">+<testsuite name='Titan' tests='30' failures='4' errors='3' skipped='0' inconc='0' time='MASKED'></span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach' time='MASKED'/></span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach_mnc3' time='MASKED'/></span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach_umts_aka_umts_res' time='MASKED'/></span><br><span>@@ -63,4 +63,5 @@</span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_echo' time='MASKED'/></span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_create' time='MASKED'/></span><br><span>   <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_deact_mt_t3395_expire' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+    <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_user_error_ind_ggsn' time='MASKED'/></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10037">change 10037</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10037"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I40e877f4126e62a731b071ae1d6d855fed210433 </div>
<div style="display:none"> Gerrit-Change-Number: 10037 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>