<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10006">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp: Avoid freeing pdp contexts during DEL CTX REQ<br><br>This may still be useful during REPLY time, for instance to hook to<br>delete_cb in order to know when the pdp ctx has really been deleted.<br><br>Change-Id: I29d366253bb98dcba328c7ce8aa3e4daf8f75e6c<br>---<br>M gtp/gtp.c<br>1 file changed, 0 insertions(+), 32 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/06/10006/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 1309cb5..77d7c56 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -2346,7 +2346,6 @@</span><br><span>             get_default_gtp(pdp->version, GTP_DELETE_PDP_REQ, &packet);</span><br><span>       struct in_addr addr;</span><br><span>         struct pdp_t *linked_pdp;</span><br><span style="color: hsl(0, 100%, 40%);">-       struct pdp_t *secondary_pdp;</span><br><span>         int n;</span><br><span>       int count = 0;</span><br><span> </span><br><span>@@ -2383,37 +2382,6 @@</span><br><span> </span><br><span>      gtp_req(gsn, pdp->version, pdp, &packet, length, &addr, cbp);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (teardown) {         /* Remove all contexts */</span><br><span style="color: hsl(0, 100%, 40%);">-               for (n = 0; n < PDP_MAXNSAPI; n++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (linked_pdp->secondary_tei[n]) {</span><br><span style="color: hsl(0, 100%, 40%);">-                          if (pdp_getgtp1</span><br><span style="color: hsl(0, 100%, 40%);">-                             (&secondary_pdp,</span><br><span style="color: hsl(0, 100%, 40%);">-                                     linked_pdp->secondary_tei[n])) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                        LOGP(DLGTP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                                         "Unknown secondary PDP context\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                                   return EOF;</span><br><span style="color: hsl(0, 100%, 40%);">-                             }</span><br><span style="color: hsl(0, 100%, 40%);">-                               if (linked_pdp != secondary_pdp) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                      if (gsn->cb_delete_context)</span><br><span style="color: hsl(0, 100%, 40%);">-                                          gsn->cb_delete_context</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   (secondary_pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                                    pdp_freepdp(secondary_pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                             }</span><br><span style="color: hsl(0, 100%, 40%);">-                       }</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (gsn->cb_delete_context)</span><br><span style="color: hsl(0, 100%, 40%);">-                  gsn->cb_delete_context(linked_pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-          pdp_freepdp(linked_pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-        } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                if (gsn->cb_delete_context)</span><br><span style="color: hsl(0, 100%, 40%);">-                  gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-         if (pdp == linked_pdp) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        linked_pdp->secondary_tei[pdp->nsapi & 0xf0] = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                     linked_pdp->nodata = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-              } else</span><br><span style="color: hsl(0, 100%, 40%);">-                  pdp_freepdp(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10006">change 10006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I29d366253bb98dcba328c7ce8aa3e4daf8f75e6c </div>
<div style="display:none"> Gerrit-Change-Number: 10006 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>