<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9988">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn<br><br>According to 3GPP TS 29.060 section "7.3.5<br>Delete PDP Context Request", both directions are valid in both GSNs.<br><br>This allows osmo-sgsn receive delete ctx indication (cb_delete_context)<br>in order to implement GGSN initiated requests.<br><br>Change-Id: I6927c07be4ddf74defe338d01d947056e15cd14d<br>---<br>M gtp/gtp.c<br>1 file changed, 4 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index ac3ec99..5b83d20 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -2830,8 +2830,7 @@</span><br><span> </span><br><span>                if ((gsn->mode == GTP_MODE_GGSN) &&</span><br><span>                   ((pheader->type == GTP_CREATE_PDP_RSP) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_UPDATE_PDP_RSP) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_DELETE_PDP_RSP))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  (pheader->type == GTP_UPDATE_PDP_RSP))) {</span><br><span>                    gsn->unexpect++;</span><br><span>                  GTP_LOGPKG(LOGL_ERROR, &peer, buffer,</span><br><span>                                status,</span><br><span>@@ -2842,8 +2841,7 @@</span><br><span> </span><br><span>              if ((gsn->mode == GTP_MODE_SGSN) &&</span><br><span>                   ((pheader->type == GTP_CREATE_PDP_REQ) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_UPDATE_PDP_REQ) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_DELETE_PDP_REQ))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  (pheader->type == GTP_UPDATE_PDP_REQ))) {</span><br><span>                    gsn->unexpect++;</span><br><span>                  GTP_LOGPKG(LOGL_ERROR, &peer, buffer,</span><br><span>                                status,</span><br><span>@@ -3009,8 +3007,7 @@</span><br><span> </span><br><span>              if ((gsn->mode == GTP_MODE_GGSN) &&</span><br><span>                   ((pheader->type == GTP_CREATE_PDP_RSP) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_UPDATE_PDP_RSP) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_DELETE_PDP_RSP))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  (pheader->type == GTP_UPDATE_PDP_RSP))) {</span><br><span>                    gsn->unexpect++;</span><br><span>                  GTP_LOGPKG(LOGL_ERROR, &peer, buffer,</span><br><span>                                status,</span><br><span>@@ -3021,8 +3018,7 @@</span><br><span> </span><br><span>              if ((gsn->mode == GTP_MODE_SGSN) &&</span><br><span>                   ((pheader->type == GTP_CREATE_PDP_REQ) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_UPDATE_PDP_REQ) ||</span><br><span style="color: hsl(0, 100%, 40%);">-                     (pheader->type == GTP_DELETE_PDP_REQ))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  (pheader->type == GTP_UPDATE_PDP_REQ))) {</span><br><span>                    gsn->unexpect++;</span><br><span>                  GTP_LOGPKG(LOGL_ERROR, &peer, buffer,</span><br><span>                                status,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9988">change 9988</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9988"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6927c07be4ddf74defe338d01d947056e15cd14d </div>
<div style="display:none"> Gerrit-Change-Number: 9988 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>