<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10019">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: gtp: Avoid leaking pdp ctx in libgtp<br><br>Nowadays sgsn_pdp_ctx_free() takes care of freeing the underlaying gtp<br>object if available. Don't bypass this check, as libgtp<br>sgsn_pdp_ctx_free() doesn't free the pdp ctx obj after the osmo-sgsn<br>cb_conf callback is called, so it needs to be freed with pdp_freepdp.<br><br>Change-Id: I304c59de5d137b81de3c6df0fdbe911ae3dbd1f3<br>---<br>M src/gprs/sgsn_libgtp.c<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/19/10019/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c</span><br><span>index 659392e..6d5b9df 100644</span><br><span>--- a/src/gprs/sgsn_libgtp.c</span><br><span>+++ b/src/gprs/sgsn_libgtp.c</span><br><span>@@ -566,10 +566,6 @@</span><br><span>                          "is not available\n");</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* unlink the now non-existing library handle from the pdp</span><br><span style="color: hsl(0, 100%, 40%);">-       * context */</span><br><span style="color: hsl(0, 100%, 40%);">-   pctx->lib = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         sgsn_pdp_ctx_free(pctx);</span><br><span> </span><br><span>         return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10019">change 10019</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10019"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I304c59de5d137b81de3c6df0fdbe911ae3dbd1f3 </div>
<div style="display:none"> Gerrit-Change-Number: 10019 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>