<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10003">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Fix T3395 firing forever<br><br>Change-Id: Iacce3c66f61578ebee37abaa287f7e183f985c1c<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/03/10003/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index ad56c60..59fcbad 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -2720,11 +2720,11 @@</span><br><span> {</span><br><span>  struct sgsn_pdp_ctx *pdp = _pdp;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    pdp->num_T_exp++;</span><br><span style="color: hsl(120, 100%, 40%);">+  unsigned int num_expired = pdp->num_T_exp + 1;</span><br><span> </span><br><span>        switch (pdp->T) {</span><br><span>         case 3395:      /* waiting for PDP CTX DEACT ACK */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (pdp->num_T_exp >= 4) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (num_expired >= 5) {</span><br><span>                   LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired >= 5 times\n");</span><br><span>                     pdp->state = PDP_STATE_INACTIVE;</span><br><span>                  if (pdp->ggsn)</span><br><span>@@ -2734,6 +2734,8 @@</span><br><span>                    break;</span><br><span>               }</span><br><span>            gsm48_tx_gsm_deact_pdp_req(pdp, GSM_CAUSE_NET_FAIL, true);</span><br><span style="color: hsl(120, 100%, 40%);">+            /* num_T_exp is reset by above function */</span><br><span style="color: hsl(120, 100%, 40%);">+            pdp->num_T_exp = num_expired;</span><br><span>             break;</span><br><span>       default:</span><br><span>             LOGPDPCTXP(LOGL_ERROR, pdp, "timer expired in unknown mode %u\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10003">change 10003</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10003"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iacce3c66f61578ebee37abaa287f7e183f985c1c </div>
<div style="display:none"> Gerrit-Change-Number: 10003 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>