<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9998">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: fix f_gen_ass_req(): populate codec list<br><br>f_gen_ass_req() looks like it generates a valid assignment request, but<br>actually lacks the Speech Codec List IE.<br><br>At least the following tests dispatch an erratic Assignment Request and expect<br>failure, but were so far failing just because the Speech Codec List IE was<br>missing:<br><br>* TC_assignment_csd()<br>* TC_assignment_ctm()<br><br>The same bit me when I was trying to add TC_assignment_chan_act_nack().<br><br>Rather set some default codec list in f_gen_ass_req(). Callers that explicitly<br>want a specific or omitted Speech Codec List (e.g.<br>TC_assignment_fr_a5_1_codec_missing()) may still modify the returned template.<br><br>Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/9998/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 2897a0b..f407e58 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -572,6 +572,7 @@</span><br><span>                 var BSSMAP_IE_CircuitIdentityCode cic := valueof(ts_BSSMAP_IE_CIC(0,1));</span><br><span>             ass_cmd := valueof(ts_BSSMAP_AssignmentReq(cic, omit));</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));</span><br><span>     return ass_cmd;</span><br><span> }</span><br><span> </span><br><span>@@ -1630,6 +1631,7 @@</span><br><span>     const OCT8 kc := '0001020304050607'O;</span><br><span> </span><br><span>    ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);</span><br><span style="color: hsl(120, 100%, 40%);">+        ass_cmd.pdu.bssmap.assignmentRequest.codecList := omit;</span><br><span>      f_establish_fully(ass_cmd, exp_fail);</span><br><span> }</span><br><span> testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9998">change 9998</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9998"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f </div>
<div style="display:none"> Gerrit-Change-Number: 9998 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>