<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9983">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl: ctrl_handle_msg: Avoid sending back received ERROR msgs<br><br>Change-Id: I396fd1e7548beea31b2b7aa9f764edb765b02941<br>---<br>M src/ctrl/control_if.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/9983/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c</span><br><span>index d3e6fac..5962f7e 100644</span><br><span>--- a/src/ctrl/control_if.c</span><br><span>+++ b/src/ctrl/control_if.c</span><br><span>@@ -384,6 +384,7 @@</span><br><span> int ctrl_handle_msg(struct ctrl_handle *ctrl, struct ctrl_connection *ccon, struct msgb *msg)</span><br><span> {</span><br><span>    struct ctrl_cmd *cmd;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool parse_failed;</span><br><span>   struct ipaccess_head *iph;</span><br><span>   struct ipaccess_head_ext *iph_ext;</span><br><span>   int result;</span><br><span>@@ -407,7 +408,7 @@</span><br><span> </span><br><span>        msg->l2h = iph_ext->data;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     cmd = ctrl_cmd_parse2(ccon, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+     cmd = ctrl_cmd_parse3(ccon, msg, &parse_failed);</span><br><span> </span><br><span>     if (!cmd) {</span><br><span>          /* should never happen */</span><br><span>@@ -421,7 +422,7 @@</span><br><span>      }</span><br><span> </span><br><span>        /* In case of error, reply with the error message right away. */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (cmd->type == CTRL_TYPE_ERROR)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (cmd->type == CTRL_TYPE_ERROR && parse_failed)</span><br><span>                 goto send_reply;</span><br><span> </span><br><span>         cmd->ccon = ccon;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9983">change 9983</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9983"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I396fd1e7548beea31b2b7aa9f764edb765b02941 </div>
<div style="display:none"> Gerrit-Change-Number: 9983 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>