<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9982">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl: Avoid sending back received ERROR msgs<br><br>Change-Id: If0cd4d435acd13dd132248c521e6bb0182de0deb<br>---<br>M src/osmo-bsc/osmo_bsc_ctrl.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/9982/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>index 13cf98d..77087c5 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_ctrl.c</span><br><span>@@ -110,16 +110,17 @@</span><br><span> int bsc_sccplite_rx_ctrl(struct osmo_ss7_asp *asp, struct msgb *msg)</span><br><span> {</span><br><span>    struct ctrl_cmd *cmd;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool parse_failed;</span><br><span>   int rc;</span><br><span> </span><br><span>  /* caller has already ensured ipaccess_head + ipaccess_head_ext */</span><br><span>   OSMO_ASSERT(msg->l2h);</span><br><span> </span><br><span>        /* prase raw (ASCII) CTRL command into ctrl_cmd */</span><br><span style="color: hsl(0, 100%, 40%);">-      cmd = ctrl_cmd_parse2(asp, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+      cmd = ctrl_cmd_parse3(asp, msg, &parse_failed);</span><br><span>  OSMO_ASSERT(cmd);</span><br><span>    msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- if (cmd->type == CTRL_TYPE_ERROR)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (cmd->type == CTRL_TYPE_ERROR && parse_failed)</span><br><span>                 goto send_reply;</span><br><span> </span><br><span>         /* handle the CTRL command */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9982">change 9982</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9982"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If0cd4d435acd13dd132248c521e6bb0182de0deb </div>
<div style="display:none"> Gerrit-Change-Number: 9982 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>