<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9981">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: ctrl: Avoid sending back received ERROR msgs<br><br>Change-Id: Ib5963e4d15a4a6b077d7a97fbbde6e5134c77e9a<br>---<br>M openbsc/src/osmo-bsc/osmo_bsc_msc.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/81/9981/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/osmo-bsc/osmo_bsc_msc.c b/openbsc/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>index 4395c3b..b179ff1 100644</span><br><span>--- a/openbsc/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>+++ b/openbsc/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>@@ -224,9 +224,10 @@</span><br><span> {</span><br><span>      int ret;</span><br><span>     struct ctrl_cmd *cmd;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool parse_failed;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  cmd = ctrl_cmd_parse2(msc->msc_con, msg);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (cmd->type == CTRL_TYPE_ERROR) {</span><br><span style="color: hsl(120, 100%, 40%);">+        cmd = ctrl_cmd_parse3(msc->msc_con, msg, &parse_failed);</span><br><span style="color: hsl(120, 100%, 40%);">+       if (cmd->type == CTRL_TYPE_ERROR && parse_failed) {</span><br><span>               LOGP(DMSC, LOGL_ERROR, "Failed to parse control message.\n");</span><br><span> </span><br><span>          ctrl_cmd_send(&msc->msc_con->write_queue, cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9981">change 9981</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9981"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib5963e4d15a4a6b077d7a97fbbde6e5134c77e9a </div>
<div style="display:none"> Gerrit-Change-Number: 9981 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>