<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9956">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix two memleaks in ipa_rx_msg_sccp()<br><br>1: Do not call xua_msg_alloc() which is later bluntly overwritten by<br>m3ua_xfer_from_data().<br><br>2: After dispatching to m3ua_hmdc_rx_from_l2(), call xua_msg_free().<br><br>Related: OS#3393<br>Change-Id: I0918f9bbc15b036619f1c25a133b69819b2a30fa<br>---<br>M src/ipa.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipa.c b/src/ipa.c</span><br><span>index e15b1d8..f3a7a52 100644</span><br><span>--- a/src/ipa.c</span><br><span>+++ b/src/ipa.c</span><br><span>@@ -202,8 +202,9 @@</span><br><span> </span><br><span> static int ipa_rx_msg_sccp(struct osmo_ss7_asp *asp, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span>      struct m3ua_data_hdr data_hdr;</span><br><span style="color: hsl(0, 100%, 40%);">-  struct xua_msg *xua = xua_msg_alloc();</span><br><span style="color: hsl(120, 100%, 40%);">+        struct xua_msg *xua;</span><br><span>         struct osmo_ss7_as *as = find_as_for_asp(asp);</span><br><span>       uint32_t opc, dpc;</span><br><span> </span><br><span>@@ -263,7 +264,9 @@</span><br><span>         m3ua_dh_to_xfer_param(&xua->mtp, &data_hdr);</span><br><span> </span><br><span>  /* Pass on as if we had received it from an M3UA ASP */</span><br><span style="color: hsl(0, 100%, 40%);">- return m3ua_hmdc_rx_from_l2(asp->inst, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = m3ua_hmdc_rx_from_l2(asp->inst, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+ xua_msg_free(xua);</span><br><span style="color: hsl(120, 100%, 40%);">+    return rc;</span><br><span> }</span><br><span> </span><br><span> /*! \brief process M3UA message received from socket</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9956">change 9956</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9956"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0918f9bbc15b036619f1c25a133b69819b2a30fa </div>
<div style="display:none"> Gerrit-Change-Number: 9956 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>