<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9975">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Pau Espin Pedrol: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_08: add function to get value string<br><br>The value string table gsm48_chan_mode_names[] lacks a function<br>to get the value string by a value. Lets add one.<br><br>Change-Id: I0757bcc278c140e18249e35864338e19cdaa3cf7<br>---<br>M include/osmocom/gsm/protocol/gsm_04_08.h<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>index 4c98ff2..4635014 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>@@ -553,6 +553,8 @@</span><br><span> };</span><br><span> </span><br><span> extern const struct value_string gsm48_chan_mode_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *gsm48_chan_mode_name(enum gsm48_chan_mode val)</span><br><span style="color: hsl(120, 100%, 40%);">+{ return get_value_string(gsm48_chan_mode_names, val); }</span><br><span> </span><br><span> /* Chapter 9.1.2 */</span><br><span> struct gsm48_ass_cmd {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9975">change 9975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0757bcc278c140e18249e35864338e19cdaa3cf7 </div>
<div style="display:none"> Gerrit-Change-Number: 9975 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>