<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9938">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy()<br><br>Change-Id: Ibf870ae02be706f802482f7cff6589a70cde8320<br>---<br>M src/vty/command.c<br>1 file changed, 1 insertion(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 689609c..51dece3 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -1311,18 +1311,11 @@</span><br><span>          * match check for "blah"</span><br><span>   */</span><br><span>  size_t len = strlen(str);</span><br><span style="color: hsl(0, 100%, 40%);">-       char *tmp;</span><br><span> </span><br><span>       if (len < 3)</span><br><span>              return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        /* tmp will hold a string of len-2 chars, so 'len' size is fine */</span><br><span style="color: hsl(0, 100%, 40%);">-      tmp = talloc_size(tall_vty_cmd_ctx, len);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       memcpy(tmp, (str + 1), len - 2);</span><br><span style="color: hsl(0, 100%, 40%);">-        tmp[len - 2] = '\0';</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    return tmp;</span><br><span style="color: hsl(120, 100%, 40%);">+   return talloc_strndup(tall_vty_cmd_ctx, str + 1, len - 2);</span><br><span> }</span><br><span> </span><br><span> static enum match_type</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9938">change 9938</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9938"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ibf870ae02be706f802482f7cff6589a70cde8320 </div>
<div style="display:none"> Gerrit-Change-Number: 9938 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>