<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9924">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sniffer: set LED pattern<br><br>The red and green LEDs are now used as follows:<br>- red on = power (firmware is running)<br>- red blink = error detected (e.g. during ISO-7816 parsing)<br>- green on = running (sniffer mode is running)<br>- green blink = activity (e.g. USB message sent)<br><br>Change-Id: Ib1b6ff87fb92d6ed3ecae4bc89386206aaab508e<br>---<br>M firmware/apps/trace/main.c<br>M firmware/libcommon/source/sniffer.c<br>2 files changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/apps/trace/main.c b/firmware/apps/trace/main.c</span><br><span>index 6b6d70b..f7eb15d 100644</span><br><span>--- a/firmware/apps/trace/main.c</span><br><span>+++ b/firmware/apps/trace/main.c</span><br><span>@@ -142,10 +142,15 @@</span><br><span>         enum confNum last_simtrace_config = simtrace_config;</span><br><span>         unsigned int i = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Configure LED output (red = on, green = activity */</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Configure LED output</span><br><span style="color: hsl(120, 100%, 40%);">+        * red on = power</span><br><span style="color: hsl(120, 100%, 40%);">+      * red blink = error</span><br><span style="color: hsl(120, 100%, 40%);">+   * green on = running</span><br><span style="color: hsl(120, 100%, 40%);">+  * green blink = activity</span><br><span style="color: hsl(120, 100%, 40%);">+      */</span><br><span>  led_init();</span><br><span>  led_blink(LED_RED, BLINK_ALWAYS_ON);</span><br><span style="color: hsl(0, 100%, 40%);">-    led_blink(LED_GREEN, BLINK_ALWAYS_OFF);</span><br><span style="color: hsl(120, 100%, 40%);">+       led_blink(LED_GREEN, BLINK_ALWAYS_ON);</span><br><span> </span><br><span>   /* Enable watchdog for 2000 ms, with no window */</span><br><span>    WDT_Enable(WDT, WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT |</span><br><span>diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c</span><br><span>index 8262bec..9202d8e 100644</span><br><span>--- a/firmware/libcommon/source/sniffer.c</span><br><span>+++ b/firmware/libcommon/source/sniffer.c</span><br><span>@@ -302,7 +302,7 @@</span><br><span>         }</span><br><span> </span><br><span>        /* Show activity on LED */</span><br><span style="color: hsl(0, 100%, 40%);">-      led_blink(LED_GREEN, BLINK_2O_F);</span><br><span style="color: hsl(120, 100%, 40%);">+     led_blink(LED_GREEN, BLINK_2F_O);</span><br><span> </span><br><span>        /* Print message */</span><br><span>  switch (type) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9924">change 9924</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9924"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib1b6ff87fb92d6ed3ecae4bc89386206aaab508e </div>
<div style="display:none"> Gerrit-Change-Number: 9924 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>