<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9944">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sniffer: fix inverted reset meaning<br><br>Change-Id: I860e2e29c059e1e0ec126695bb68d489891a17da<br>---<br>M firmware/libcommon/source/sniffer.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/44/9944/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c</span><br><span>index 0ca71a5..c58b047 100644</span><br><span>--- a/firmware/libcommon/source/sniffer.c</span><br><span>+++ b/firmware/libcommon/source/sniffer.c</span><br><span>@@ -832,11 +832,11 @@</span><br><span>          TRACE_ERROR("Pin other than reset caused a interrupt\n\r");</span><br><span>                return;</span><br><span>      }</span><br><span style="color: hsl(0, 100%, 40%);">-       /* Update the ISO state according to the reset change */</span><br><span style="color: hsl(120, 100%, 40%);">+      /* Update the ISO state according to the reset change (reset is active low) */</span><br><span>       if (PIO_Get(&pin_rst)) {</span><br><span style="color: hsl(0, 100%, 40%);">-            change_flags |= SNIFF_CHANGE_FLAG_RESET_HOLD; /* set flag and let main loop send it */</span><br><span style="color: hsl(0, 100%, 40%);">-  } else {</span><br><span>             change_flags |= SNIFF_CHANGE_FLAG_RESET_RELEASE; /* set flag and let main loop send it */</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              change_flags |= SNIFF_CHANGE_FLAG_RESET_HOLD; /* set flag and let main loop send it */</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span>@@ -1011,13 +1011,13 @@</span><br><span>         /* Handle flags */</span><br><span>   if (change_flags) { /* WARNING this is not synced with the data buffer handling */</span><br><span>           if (change_flags & SNIFF_CHANGE_FLAG_RESET_HOLD) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  if (ISO7816_S_WAIT_ATR != iso_state) {</span><br><span style="color: hsl(0, 100%, 40%);">-                          change_state(ISO7816_S_WAIT_ATR);</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (ISO7816_S_RESET != iso_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           change_state(ISO7816_S_RESET);</span><br><span>                       }</span><br><span>            }</span><br><span>            if (change_flags & SNIFF_CHANGE_FLAG_RESET_RELEASE) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (ISO7816_S_RESET != iso_state) {</span><br><span style="color: hsl(0, 100%, 40%);">-                             change_state(ISO7816_S_RESET);</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (ISO7816_S_WAIT_ATR != iso_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                change_state(ISO7816_S_WAIT_ATR);</span><br><span>                    }</span><br><span>            }</span><br><span>            if (change_flags & SNIFF_CHANGE_FLAG_TIMEOUT_WT) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9944">change 9944</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9944"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I860e2e29c059e1e0ec126695bb68d489891a17da </div>
<div style="display:none"> Gerrit-Change-Number: 9944 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>