<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9876">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">console: drop data to be send when buffer is already full<br><br>don't wait for space to be available in the buffer since since would<br>prevent from processing non-console (e.g. debug) more important data<br><br>Change-Id: Ia625b09eb30bb7b43edd3989f697d8ef33200f28<br>---<br>M firmware/libboard/common/source/uart_console.c<br>1 file changed, 8 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/9876/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/common/source/uart_console.c b/firmware/libboard/common/source/uart_console.c</span><br><span>index e52cd51..a47ba0c 100644</span><br><span>--- a/firmware/libboard/common/source/uart_console.c</span><br><span>+++ b/firmware/libboard/common/source/uart_console.c</span><br><span>@@ -133,17 +133,15 @@</span><br><span> UART_Configure(CONSOLE_BAUDRATE, BOARD_MCK);
</span><br><span> }
</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Wait until there is space in the buffer */
</span><br><span style="color: hsl(0, 100%, 40%);">- while (rbuf_is_full(&uart_tx_buffer)) {
</span><br><span style="color: hsl(0, 100%, 40%);">- if (pUart->UART_SR & UART_SR_TXEMPTY) {
</span><br><span style="color: hsl(0, 100%, 40%);">- pUart->UART_IER = UART_IER_TXRDY;
</span><br><span style="color: hsl(0, 100%, 40%);">- CONSOLE_ISR();
</span><br><span style="color: hsl(0, 100%, 40%);">- }
</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Only store input if buffer is not full, else drop it */
</span><br><span style="color: hsl(120, 100%, 40%);">+ bool trigger_isr = false;
</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rbuf_is_empty(&uart_tx_buffer)) {
</span><br><span style="color: hsl(120, 100%, 40%);">+ trigger_isr = true;
</span><br><span> }
</span><br><span style="color: hsl(0, 100%, 40%);">-
</span><br><span style="color: hsl(0, 100%, 40%);">- /* Put character into buffer */
</span><br><span style="color: hsl(0, 100%, 40%);">- rbuf_write(&uart_tx_buffer, c);
</span><br><span style="color: hsl(0, 100%, 40%);">- if (pUart->UART_SR & UART_SR_TXEMPTY) {
</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rbuf_is_full(&uart_tx_buffer)) {
</span><br><span style="color: hsl(120, 100%, 40%);">+ rbuf_write(&uart_tx_buffer, c);
</span><br><span style="color: hsl(120, 100%, 40%);">+ }
</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trigger_isr) {
</span><br><span> pUart->UART_IER = UART_IER_TXRDY;
</span><br><span> CONSOLE_ISR();
</span><br><span> }
</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9876">change 9876</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9876"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia625b09eb30bb7b43edd3989f697d8ef33200f28 </div>
<div style="display:none"> Gerrit-Change-Number: 9876 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>