<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9763">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Init access_lists before passing it as a parameter<br><br>Previous state is harmless because the pointer is stored but not used in<br>that function. However, it's more clear this way.<br><br>Change-Id: I048ebc120306ea30ea973d6ee16ed84c9f341183<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index 69db32e..1f951b1 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -72,7 +72,7 @@</span><br><span> static const char *config_file = "osmo-bsc.cfg";</span><br><span> static const char *rf_ctrl = NULL;</span><br><span> static int daemonize = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-static struct llist_head access_lists;</span><br><span style="color: hsl(120, 100%, 40%);">+static LLIST_HEAD(access_lists);</span><br><span> </span><br><span> struct llist_head *bsc_access_lists(void)</span><br><span> {</span><br><span>@@ -812,8 +812,6 @@</span><br><span>    osmo_ss7_init();</span><br><span>     osmo_ss7_vty_init_asp(tall_bsc_ctx);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        INIT_LLIST_HEAD(&access_lists);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  /* parse options */</span><br><span>  handle_options(argc, argv);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9763">change 9763</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9763"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I048ebc120306ea30ea973d6ee16ed84c9f341183 </div>
<div style="display:none"> Gerrit-Change-Number: 9763 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>