<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9729">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check bssgp_tlv_parse() return code in bssgp_rcvmsg()<br><br>The return code from bssgp_tlv_parse() was not checked for a parsing<br>error. In case of a parsing error the stored return code could have<br>been overwritten later in this function.<br><br>Explicitly check for a parsing error and log corresponding packets.<br><br>Change-Id: Id3d7c52ec3df2bcf4efcee0e0b14fe22ef96964e<br>Related: OS#3178<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index d5d4ea8..1445a56 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -1049,6 +1049,11 @@</span><br><span>                data_len = msgb_bssgp_len(msg) - sizeof(*budh);</span><br><span>              rc = bssgp_tlv_parse(&tp, budh->data, data_len);</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  bssgp_pdu_str(pdu_type), msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+             return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        if (bvci == BVCI_SIGNALLING && TLVP_PRESENT(&tp, BSSGP_IE_BVCI))</span><br><span>                 bvci = tlvp_val16be(&tp, BSSGP_IE_BVCI);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9729">change 9729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id3d7c52ec3df2bcf4efcee0e0b14fe22ef96964e </div>
<div style="display:none"> Gerrit-Change-Number: 9729 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>