<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9727">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log reception of PCU_IF_MSG_PAG_REQ messages from osmo-pcu<br><br>osmo-pcu currently sends paging requests in PCU_IF_MSG_DATA_REQ<br>messages, rather than PCU_IF_MSG_PAG_REQ. Clarify a comment which<br>already alluded to this, and leave an explicit log entry if a<br>PCU_IF_MSG_PAG_REQ message is received.<br><br>Change-Id: I75fd8f051f943d876b5614fa088fff7e56b310ab<br>Related: OS#3018<br>---<br>M src/common/pcu_sock.c<br>1 file changed, 22 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/9727/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index bdebf65..7f32f32 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -481,13 +481,7 @@</span><br><span> </span><br><span> switch (data_req->sapi) {</span><br><span> case PCU_IF_SAPI_PCH:</span><br><span style="color: hsl(0, 100%, 40%);">- if (msg_type == PCU_IF_MSG_PAG_REQ) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: Add function to schedule paging request.</span><br><span style="color: hsl(0, 100%, 40%);">- * This might not be required, if PCU_IF_MSG_DATA_REQ</span><br><span style="color: hsl(0, 100%, 40%);">- * is used instead. */</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- paging_add_imm_ass(bts->paging_state, data_req->data, data_req->len);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ paging_add_imm_ass(bts->paging_state, data_req->data, data_req->len);</span><br><span> break;</span><br><span> case PCU_IF_SAPI_AGCH:</span><br><span> msg = msgb_alloc(data_req->len, "pcu_agch");</span><br><span>@@ -543,6 +537,24 @@</span><br><span> return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int pcu_rx_pag_req(struct gsm_bts *bts, uint8_t msg_type,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_pcu_if_pag_req *pag_req)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(msg_type == PCU_IF_MSG_PAG_REQ);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: Add function to schedule paging request.</span><br><span style="color: hsl(120, 100%, 40%);">+ * At present, osmo-pcu sends paging requests in PCU_IF_MSG_DATA_REQ</span><br><span style="color: hsl(120, 100%, 40%);">+ * messages which are processed by pcu_rx_data_req().</span><br><span style="color: hsl(120, 100%, 40%);">+ * This code path is not triggered in practice. */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DPCU, LOGL_NOTICE, "Paging request received: chan_needed=%d length=%d "</span><br><span style="color: hsl(120, 100%, 40%);">+ "(dropping message because support for PCU_IF_MSG_PAG_REQ is not yet implemented)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ pag_req->chan_needed, pag_req->identity_lv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int pcu_tx_si13(const struct gsm_bts *bts, bool enable)</span><br><span> {</span><br><span> /* the SI is per-BTS so it doesn't matter which TRX we use */</span><br><span>@@ -631,9 +643,11 @@</span><br><span> </span><br><span> switch (msg_type) {</span><br><span> case PCU_IF_MSG_DATA_REQ:</span><br><span style="color: hsl(0, 100%, 40%);">- case PCU_IF_MSG_PAG_REQ:</span><br><span> rc = pcu_rx_data_req(bts, msg_type, &pcu_prim->u.data_req);</span><br><span> break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCU_IF_MSG_PAG_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = pcu_rx_pag_req(bts, msg_type, &pcu_prim->u.pag_req);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> case PCU_IF_MSG_ACT_REQ:</span><br><span> rc = pcu_rx_act_req(bts, &pcu_prim->u.act_req);</span><br><span> break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9727">change 9727</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9727"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I75fd8f051f943d876b5614fa088fff7e56b310ab </div>
<div style="display:none"> Gerrit-Change-Number: 9727 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>