<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9728">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check bssgp_tlv_parse() return code in gprs_bssgp_pcu_rcvmsg()<br><br>The return code from bssgp_tlv_parse() was not checked for a parsing<br>error. In case of a parsing error the stored return code could have<br>been overwritten later in this function.<br><br>Explicitly check for a parsing error and log corresponding packets.<br><br>Change-Id: I56e10a97cda7fd2d40bc7b4b2e6202f97772e1b3<br>Related: OS#3178<br>---<br>M src/gprs_bssgp_pcu.cpp<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/9728/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index 1524fb3..1f58809 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -388,6 +388,11 @@</span><br><span>               data_len = msgb_bssgp_len(msg) - sizeof(*budh);</span><br><span>              rc = bssgp_tlv_parse(&tp, budh->data, data_len);</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  bssgp_pdu_str(pdu_type), msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+             return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        if (pdu_type == BSSGP_PDUT_BVC_RESET) {</span><br><span>              rc = bssgp_rcvmsg(msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9728">change 9728</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9728"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I56e10a97cda7fd2d40bc7b4b2e6202f97772e1b3 </div>
<div style="display:none"> Gerrit-Change-Number: 9728 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>