<p>Stefan Sperling <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9715">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">finish gbproxy_parse_bssgp_unitdata test<br><br>The message this test is trying to parse is indeed invalid.<br>Add a comment showing the message in decoded form, and assert<br>that the parser rejects it.<br><br>Also, add a missing call to cleanup_test().<br><br>Change-Id: I2a86432d080c38d3c95626372a0129499d7146dd<br>Related: OS#3178<br>---<br>M tests/gbproxy/gbproxy_test.c<br>1 file changed, 55 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c</span><br><span>index e6bb2e6..157da8b 100644</span><br><span>--- a/tests/gbproxy/gbproxy_test.c</span><br><span>+++ b/tests/gbproxy/gbproxy_test.c</span><br><span>@@ -4944,14 +4944,64 @@</span><br><span> parse_ctx.to_bss = 0;</span><br><span> parse_ctx.peer_nsei = msgb_nsei(msg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: Determine whether our parser or the message is wrong. */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> rc = gprs_gb_parse_bssgp(msg->data, msg->len, &parse_ctx);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!rc) {</span><br><span style="color: hsl(0, 100%, 40%);">- fprintf(stderr, "%s: Failed to parse message %s\n", __func__, msgb_hexdump(msg));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rc)</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "%s: Test passed; Failed to parse invalid message %s\n", __func__, msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "%s: Test failed; invalid message was accepted by parser: %s\n", __func__, msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(!rc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Manually decoded message according to:</span><br><span style="color: hsl(120, 100%, 40%);">+ ETSI TS 148 018 V10.6.0 (2012 07) 96</span><br><span style="color: hsl(120, 100%, 40%);">+ 3GPP TS 48.018 version 10.6.0 Release 10</span><br><span style="color: hsl(120, 100%, 40%);">+ Table 10.2.2: UL-UNITDATA PDU content</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 - PDU type UL-UNITDATA (ok)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ 11.3.35 Temporary logical link Identity (TLLI)</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 - TLLI[0]</span><br><span style="color: hsl(120, 100%, 40%);">+ 23 - TLLI[1]</span><br><span style="color: hsl(120, 100%, 40%);">+ 94 - TLLI[2]</span><br><span style="color: hsl(120, 100%, 40%);">+ 01 - TLLI[3]</span><br><span style="color: hsl(120, 100%, 40%);">+ TLLI == "00239401"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ e1 - QOS[0] (bit rate MSB)</span><br><span style="color: hsl(120, 100%, 40%);">+ 55 - QOS[1] (bit rate LSB)</span><br><span style="color: hsl(120, 100%, 40%);">+ bit rate = "57685" (57685*100000 bit/s per PBRG)</span><br><span style="color: hsl(120, 100%, 40%);">+ cf - QOS[2] PBRG = 11 (bit rate is expressed in 100000 bit/s increments),</span><br><span style="color: hsl(120, 100%, 40%);">+ C/R 0 (contains LLC ACK/SACK),</span><br><span style="color: hsl(120, 100%, 40%);">+ T 0 (contains signalling),</span><br><span style="color: hsl(120, 100%, 40%);">+ A 1 (radio if uses MAC/UNITDATA,</span><br><span style="color: hsl(120, 100%, 40%);">+ Precedence 111 (reserved value)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ea - CELL_ID[0] (TLV IEI: wrong, should be 0x08)</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 - CELL_ID[1] (length 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 - CELL_ID[2] (length 2)</span><br><span style="color: hsl(120, 100%, 40%);">+ lenth == 0</span><br><span style="color: hsl(120, 100%, 40%);">+ 04 -- CELL_ID[3]</span><br><span style="color: hsl(120, 100%, 40%);">+ 08 -- CELL_ID[4]</span><br><span style="color: hsl(120, 100%, 40%);">+ 88 -- CELL_ID[5]</span><br><span style="color: hsl(120, 100%, 40%);">+ 72 -- CELL_ID[6]</span><br><span style="color: hsl(120, 100%, 40%);">+ f4 -- CELL_ID[7]</span><br><span style="color: hsl(120, 100%, 40%);">+ 80 -- CELL_ID[8]</span><br><span style="color: hsl(120, 100%, 40%);">+ 10 -- CELL_DI[9]</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ 18 -- QOSP[0] OoS Profile IEI</span><br><span style="color: hsl(120, 100%, 40%);">+ not allowed in BSSGP Userdata</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 -- QOSP[1]</span><br><span style="color: hsl(120, 100%, 40%);">+ 9c -- QOSP[2]</span><br><span style="color: hsl(120, 100%, 40%);">+ 40 -- QOSP[3]</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 -- QOSP[4]</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ 80 -- IEI for "E-UTRAN Inter RAT Handover Info"</span><br><span style="color: hsl(120, 100%, 40%);">+ not allowed in BSSGP Userdata</span><br><span style="color: hsl(120, 100%, 40%);">+ 0e -- length (14 bytes -- only 8 bytes remain)</span><br><span style="color: hsl(120, 100%, 40%);">+ 00 06 01 c0 41 6c 43 38 */</span><br><span> </span><br><span> msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ cleanup_test();</span><br><span> }</span><br><span> </span><br><span> static struct log_info_cat gprs_categories[] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9715">change 9715</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9715"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2a86432d080c38d3c95626372a0129499d7146dd </div>
<div style="display:none"> Gerrit-Change-Number: 9715 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>