<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/9686">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9686/4/msc/MSC_Tests.ttcn">File msc/MSC_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9686/4/msc/MSC_Tests.ttcn@2273">Patch Set #4, Line 2273:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">alt {<br>        [] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {<br>             setverdict(pass);<br>             }<br>     [] BSSAP.receive {<br>            setverdict(fail, "Unknown/unexpected BSSAP received");<br>              self.stop;<br>            }<br>     [] GSUP.receive {<br>             setverdict(fail, "Unexpected GSUP message received");<br>               self.stop;<br>            }<br>     }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The fact that you still have those alt-clauses here means that somehow the abstraction level chosen doesn't work.  You have not implemented the altstep suggestion that I hinted in a previous comment and instead introduced functions lie f_expect_bssap().  But then, that function works only for DTAP, so you need to open-code this again here.  The detailed design is up to you, but I think it would be good t o generalize this, i.e. either have a f_expect_bssap() that works for both dtap + bssmap, or have separate expect functions.  And independent of all of this, the "[] foo.receive {setverdict(fail); self.stop}" which are repeated in every of those functions could be an altstep, whcih is then invoked from every f_expect_ function, further  reducing code duplication.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9686">change 9686</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9686"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985 </div>
<div style="display:none"> Gerrit-Change-Number: 9686 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 25 Jun 2018 10:35:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>