<p>Holger Freyther has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9716">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ms: Quit early when all tests concluded..<br><br>And fix the the detection if everything has completed.<br><br>Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179<br>---<br>M src/osmo_ms_driver/location_update_test.py<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/16/9716/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ms_driver/location_update_test.py b/src/osmo_ms_driver/location_update_test.py</span><br><span>index 2a3c246..9bab8ad 100644</span><br><span>--- a/src/osmo_ms_driver/location_update_test.py</span><br><span>+++ b/src/osmo_ms_driver/location_update_test.py</span><br><span>@@ -35,6 +35,9 @@</span><br><span>         assert self._time_of_lu is None</span><br><span>         self._time_of_lu = time</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    def has_lu_time(self):</span><br><span style="color: hsl(120, 100%, 40%);">+        return self._time_of_lu is not None</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     def lu_time(self):</span><br><span>         return self._time_of_lu or 0</span><br><span> </span><br><span>@@ -165,7 +168,7 @@</span><br><span>     def wait_for_result(self, loop):</span><br><span>         to_complete_time = self._start_time + self.TEST_TIME.total_seconds()</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        while True:</span><br><span style="color: hsl(120, 100%, 40%);">+        while not self.all_completed():</span><br><span>             now_time = time.clock_gettime(time.CLOCK_MONOTONIC)</span><br><span>             sleep_time = to_complete_time - now_time</span><br><span>             if sleep_time < 0:</span><br><span>@@ -173,9 +176,12 @@</span><br><span>             loop.schedule_timeout(sleep_time)</span><br><span>             loop.select()</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def print_stats(self):</span><br><span style="color: hsl(120, 100%, 40%);">+    def all_completed(self):</span><br><span>         from functools import reduce</span><br><span style="color: hsl(0, 100%, 40%);">-        all_completed = reduce(lambda b, ms: b and ms.lu_time() is not None, self._results.values(), True)</span><br><span style="color: hsl(120, 100%, 40%);">+        return reduce(lambda b, ms: b and ms.has_lu_time(), self._results.values(), True)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    def print_stats(self):</span><br><span style="color: hsl(120, 100%, 40%);">+        all_completed = self.all_completed()</span><br><span>         min_value = min(self._results.values(), key=lambda x: x.lu_delay())</span><br><span>         max_value = max(self._results.values(), key=lambda x: x.lu_delay())</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9716">change 9716</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9716"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179 </div>
<div style="display:none"> Gerrit-Change-Number: 9716 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>