<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9706">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0<br><br>Fixes following compilation warning:<br>In file included from l1_if.c:32:0:<br>l1_if.c: In function ‘l1if_mute_rf’:<br>/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ [-Werror=sizeof-array-argument]<br> #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))<br> ^<br>l1_if.c:1405:29: note: in expansion of macro ‘ARRAY_SIZE’<br> if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {<br> ^~~~~~~~~~<br>l1_if.c:1388:51: note: declared here<br> int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)<br> ^~~~<br>In file included from l1_if.c:32:0:<br>/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ [-Werror=sizeof-array-argument]<br> #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))<br> ^<br>l1_if.c:1408:19: note: in expansion of macro ‘ARRAY_SIZE’<br> for (i = 0; i < ARRAY_SIZE(mute); ++i)<br> ^~~~~~~~~~<br>l1_if.c:1388:51: note: declared here<br> int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)<br> ^~~~<br><br>Change-Id: Id040aeb35549ddb75072942be0093064a89092a6<br>---<br>M src/osmo-bts-sysmo/l1_if.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/9706/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c</span><br><span>index f1c6602..7fa82f2 100644</span><br><span>--- a/src/osmo-bts-sysmo/l1_if.c</span><br><span>+++ b/src/osmo-bts-sysmo/l1_if.c</span><br><span>@@ -1402,10 +1402,10 @@</span><br><span> LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");</span><br><span> msgb_free(msg);</span><br><span> /* always acknowledge an un-MUTE (which is a no-op if MUTE is not supported */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!memcmp(mute, unmuted, ARRAY_SIZE(unmuted))) {</span><br><span> bts_update_status(BTS_STATUS_RF_MUTE, mute[0]);</span><br><span> oml_mo_rf_lock_chg(&trx->mo, mute, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < ARRAY_SIZE(mute); ++i)</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < ARRAY_SIZE(unmuted); ++i)</span><br><span> mute_handle_ts(&trx->ts[i], mute[i]);</span><br><span> return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9706">change 9706</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9706"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id040aeb35549ddb75072942be0093064a89092a6 </div>
<div style="display:none"> Gerrit-Change-Number: 9706 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>