<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9703">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_09_11.c: properly handle MS-initiated release<br><br>According to GSM TS 02.90, section 4.3, release of the connection<br>used for SS/USSD is normally the responsibility of the network.<br>But the user may also initiate connection release, e.g. by<br>pressing the 'red button'.<br><br>TTCN-3 test case: I7936ed5072ed2ae02f039dc90a1fece1e7f70a70<br>Change-Id: I76fc277bf9db614a97824b1541cd5bb75aa3e29d<br>---<br>M src/libmsc/gsm_09_11.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/03/9703/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index befb573..e7bdcf5 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -178,8 +178,11 @@</span><br><span>          goto error;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Don't release connection, wait for response */</span><br><span style="color: hsl(0, 100%, 40%);">-   msc_subscr_conn_communicating(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Should we release connection? Or wait for response? */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (msg_type == GSM0480_MTYPE_RELEASE_COMPLETE)</span><br><span style="color: hsl(120, 100%, 40%);">+               trans_free(trans);</span><br><span style="color: hsl(120, 100%, 40%);">+    else</span><br><span style="color: hsl(120, 100%, 40%);">+          msc_subscr_conn_communicating(conn);</span><br><span> </span><br><span>     return 0;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9703">change 9703</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9703"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I76fc277bf9db614a97824b1541cd5bb75aa3e29d </div>
<div style="display:none"> Gerrit-Change-Number: 9703 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>