<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9673">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: handover: actually send Handover Detect<br><br>Until now, the test went from RR Handover Command directly to RR Handover<br>Complete, and osmo-bsc didn't mind it. However, the normal handover procedure<br>requires an RSL Handover Detect to be sent in-between those. Send that.<br><br>Change-Id: I6e54edcc3a99e116d852eca8e48c7a5bc685e832<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>M library/RSL_Types.ttcn<br>2 files changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 0846762..2042979 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -877,6 +877,10 @@</span><br><span>                        * before performing a hand-over */</span><br><span>                  f_rslem_resume(RSL1_PROC);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+                        /* send handover detect */</span><br><span style="color: hsl(120, 100%, 40%);">+                    RSL1.send(ts_RSL_HANDO_DET(new_chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+                     f_sleep(0.3);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                      /* send handover complete over the new channel */</span><br><span>                    var PDU_ML3_MS_NW l3_tx := valueof(ts_RRM_HandoverComplete('00'O));</span><br><span>                  RSL1.send(ts_RSL_DATA_IND(new_chan_nr, valueof(ts_RslLinkID_DCCH(0)),</span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index 3804d40..e1f6af0 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -1309,6 +1309,15 @@</span><br><span>          }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* 8.4.7 BTS -> BSC */</span><br><span style="color: hsl(120, 100%, 40%);">+     template (value) RSL_Message ts_RSL_HANDO_DET(template (value) RslChannelNr chan_nr) := {</span><br><span style="color: hsl(120, 100%, 40%);">+             msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false),</span><br><span style="color: hsl(120, 100%, 40%);">+           msg_type := RSL_MT_HANDO_DET,</span><br><span style="color: hsl(120, 100%, 40%);">+         ies := {</span><br><span style="color: hsl(120, 100%, 40%);">+                      t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr})</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span>      /* COMMON CHANNEL MANAGEMENT MESSAGES */</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9673">change 9673</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9673"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6e54edcc3a99e116d852eca8e48c7a5bc685e832 </div>
<div style="display:none"> Gerrit-Change-Number: 9673 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>