<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9651">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsup: Add value_string for Session State IE<br><br>In Change-Id I1cee271fed0284a134ffed103c0d4bebbcfde2a8 we added support<br>for a new session state IE, but we didn't add any value_string array<br>for string conversion of it.  Let's fix this.<br><br>Change-Id: I3d9f087786dc37c42498fa9a2be07483ec93ba7b<br>---<br>M include/osmocom/gsm/gsup.h<br>M src/gsm/gsup.c<br>M src/gsm/libosmogsm.map<br>3 files changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h</span><br><span>index e246639..0ef5a75 100644</span><br><span>--- a/include/osmocom/gsm/gsup.h</span><br><span>+++ b/include/osmocom/gsm/gsup.h</span><br><span>@@ -154,6 +154,11 @@</span><br><span>   OSMO_GSUP_SESSION_STATE_END             = 0x03,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string osmo_gsup_session_state_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_gsup_session_state_name(enum osmo_gsup_session_state val)</span><br><span style="color: hsl(120, 100%, 40%);">+{     return get_value_string(osmo_gsup_session_state_names, val); }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! parsed/decoded PDP context information */</span><br><span> struct osmo_gsup_pdp_info {</span><br><span>     unsigned int                    context_id;</span><br><span>diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c</span><br><span>index e3eef02..9c2f817 100644</span><br><span>--- a/src/gsm/gsup.c</span><br><span>+++ b/src/gsm/gsup.c</span><br><span>@@ -70,6 +70,14 @@</span><br><span>        { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string osmo_gsup_session_state_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+  { OSMO_GSUP_SESSION_STATE_NONE, "NONE" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { OSMO_GSUP_SESSION_STATE_BEGIN, "BEGIN" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { OSMO_GSUP_SESSION_STATE_CONTINUE, "CONTINUE" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { OSMO_GSUP_SESSION_STATE_END, "END" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> /*! return the error message type corresponding to \a type_in</span><br><span>  *  \returns matching error message type; -1 on error */</span><br><span>diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map</span><br><span>index f98f7c9..4d9811b 100644</span><br><span>--- a/src/gsm/libosmogsm.map</span><br><span>+++ b/src/gsm/libosmogsm.map</span><br><span>@@ -469,6 +469,7 @@</span><br><span> osmo_gsup_encode;</span><br><span> osmo_gsup_decode;</span><br><span> osmo_gsup_message_type_names;</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_gsup_session_state_names;</span><br><span> osmo_gsup_get_err_msg_type;</span><br><span> </span><br><span> osmo_oap_encode;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9651">change 9651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3d9f087786dc37c42498fa9a2be07483ec93ba7b </div>
<div style="display:none"> Gerrit-Change-Number: 9651 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>