<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9647">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">disable blind subscriber insertion into every VLR/SGSN<br><br>During the attempt to fix OS#2785 in Change-Id<br>I6a92ca34cdaadca9eacc774bb1ca386c325ba865, we introduced logic that<br>would blindly insert a subscriber *concurrently* in all VLRs/SGSNs of<br>the network on any update of the subscriber.<br><br>Before that patch, we didn't update the current serving SGSN/VLR,<br>and after the change we created subscribers in all SGSNs/VLRs, of which<br>all-1 are not serving the subscriber at that time.<br><br>We'll have to go back to the original behavior until a proper fix can<br>be introduced.<br><br>Change-Id: Ibf6f1b21b08560d4d8f41bbe7782d40abf4585f8<br>Related: OS#3091<br>Related: OS#2785<br>---<br>M src/hlr.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index ee19795..940165f 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -47,14 +47,17 @@</span><br><span> </span><br><span> /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients.</span><br><span>  *</span><br><span style="color: hsl(0, 100%, 40%);">- * FIXME: In order to support large-scale networks this function should skip</span><br><span style="color: hsl(0, 100%, 40%);">- * VLRs/SGSNs which do not currently serve the subscriber.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span>  * \param[in] subscr  A subscriber we have new data to send for.</span><br><span>  */</span><br><span> void</span><br><span> osmo_hlr_subscriber_update_notify(struct hlr_subscriber *subscr)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     /* FIXME: the below code can only be re-enabled after we make sure that an ISD</span><br><span style="color: hsl(120, 100%, 40%);">+         * is only sent tot the currently serving VLR and/or SGSN (if there are any).</span><br><span style="color: hsl(120, 100%, 40%);">+  * We cannot blindly flood the entire PLMN with this, as it would create subscriber</span><br><span style="color: hsl(120, 100%, 40%);">+    * state in every VLR/SGSN out there, even those that have never seen the subscriber.</span><br><span style="color: hsl(120, 100%, 40%);">+  * See https://osmocom.org/issues/3154 for details. */</span><br><span style="color: hsl(120, 100%, 40%);">+#if 0</span><br><span>         struct osmo_gsup_conn *co;</span><br><span> </span><br><span>      if (g_hlr->gs == NULL)</span><br><span>@@ -118,6 +121,7 @@</span><br><span>                      continue;</span><br><span>            }</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> }</span><br><span> </span><br><span> /***********************************************************************</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9647">change 9647</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9647"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ibf6f1b21b08560d4d8f41bbe7782d40abf4585f8 </div>
<div style="display:none"> Gerrit-Change-Number: 9647 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>