<p>Pau Espin Pedrol <strong>uploaded patch set #3</strong> to the change originally created by Harald Welte.</p><p><a href="https://gerrit.osmocom.org/9622">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">radioDevice: better encapsulation in base class<br><br>It's not good style to have the derived classes initialize members<br>inherited from the base class using "this->foo = bar".  Rather, let's<br>make the base class have a constructor, and call that constructor to<br>initialize the members of the base class.<br><br>While doing this<br>* rename 'offset' to 'lo_offset' to avoid confusion with timestamp offset<br>* move 'InterfaceType' into the base class<br>* move 'chans' into the base class<br>* move 'rx_sps' into the base class<br>* mark base class members as 'protected'<br><br>Change-Id: Ib885675a7612a392aa7f75fca81269ddcff2f6ab<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>M Transceiver52M/device/lms/LMSDevice.h<br>M Transceiver52M/device/radioDevice.h<br>M Transceiver52M/device/uhd/UHDDevice.cpp<br>M Transceiver52M/device/usrp1/USRPDevice.cpp<br>M Transceiver52M/device/usrp1/USRPDevice.h<br>6 files changed, 38 insertions(+), 34 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/22/9622/3</pre><p>To view, visit <a href="https://gerrit.osmocom.org/9622">change 9622</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9622"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Ib885675a7612a392aa7f75fca81269ddcff2f6ab </div>
<div style="display:none"> Gerrit-Change-Number: 9622 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>