<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9627">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log / comment tweaks<br><br>MSC_ConnectionHandler: log content of IPA CRCX ACK. The IPACC CRCX isn't<br>easily readable in wireshark, and I wanted to see what we were actually<br>sending.<br><br>BSC_Tests: sprinkle logs to illustrate what the dyn PDCH tests expect.<br><br>BSC_Tests: tweak comment to mention that inter-BSC HO MT *does* allow N-CONNECT<br>from MSC.<br><br>f_tc_assignment_fr_a5_1_codec_missing: mark the missing IE beyond doubt.<br><br>Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/MSC_ConnectionHandler.ttcn<br>2 files changed, 12 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/9627/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index df51e7f..3bd1096 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -522,7 +522,8 @@</span><br><span> * Assignment Testing</span><br><span> ***********************************************************************/</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction) */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction,</span><br><span style="color: hsl(120, 100%, 40%);">+ * except for the inter-BSC handover, MT side) */</span><br><span> testcase TC_outbound_connect() runs on test_CT {</span><br><span> f_init(1);</span><br><span> </span><br><span>@@ -1577,6 +1578,8 @@</span><br><span> const OCT8 kc := '0001020304050607'O;</span><br><span> </span><br><span> ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Omit: ass_cmd.pdu.bssmap.assignmentRequest.codecList */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> f_establish_fully(ass_cmd, exp_fail);</span><br><span> }</span><br><span> testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT {</span><br><span>@@ -2289,26 +2292,31 @@</span><br><span> </span><br><span> var RslChannelNr chan_nr := valueof(t_RslChanNr_Bm(6));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan starts out in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span> rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr));</span><br><span> f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342)));</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH ACT was ACKed, so now in PDCH mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> /* De-activate it via VTY */</span><br><span> f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span> /* re-activate it via VTY */</span><br><span> f_dyn_ipa_pdch_act(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH ACT via VTY, so now in PDCH mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> /* and finally de-activate it again */</span><br><span> f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);</span><br><span> </span><br><span> setverdict(pass);</span><br><span>@@ -2401,12 +2409,14 @@</span><br><span> </span><br><span> var RslChannelNr chan_nr := valueof(t_RslChanNr_PDCH(6));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_TCH/H_PDCH pchan starts out in disabled mode:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE);</span><br><span> /* The BSC will activate the dynamic PDCH by default, so confirm that */</span><br><span> rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?));</span><br><span> </span><br><span> f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342));</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TCH/F_TCH/H_PDCH requested to PDCH ACT on startup, which was ACKed, so now in PDCH:");</span><br><span> f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);</span><br><span> </span><br><span> setverdict(pass);</span><br><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 0846762..dffe331 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -147,6 +147,7 @@</span><br><span> if (f_rsl_find_ie(rsl, RSL_IE_IPAC_RTP_PAYLOAD2, ie)) {</span><br><span> g_media.bts.rtp_pt := ie.ipa_rtp_pt2;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Sending IPA CRCX ACK: host=", g_media.bts.bts.host, " port=", g_media.bts.bts.port_nr, " pt=", g_media.bts.rtp_pt);</span><br><span> RSL.send(ts_RSL_IPA_CRCX_ACK(g_chan_nr, g_media.bts.conn_id,</span><br><span> oct2int(f_inet_addr(g_media.bts.bts.host)),</span><br><span> g_media.bts.bts.port_nr,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9627">change 9627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9627"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c </div>
<div style="display:none"> Gerrit-Change-Number: 9627 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>