<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9631">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add function gprs_nsvc_state_append<br><br>A common function to append the nsvc state from osmo-sgsn or osmo-gbproxy<br><br>Change-Id: I7f0eaff7329ab98cad792d30b20ab053007aab85<br>---<br>M include/osmocom/gprs/gprs_ns.h<br>M src/gb/gprs_ns.c<br>M src/gb/libosmogb.map<br>3 files changed, 25 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/9631/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h</span><br><span>index b368ad9..7b95099 100644</span><br><span>--- a/include/osmocom/gprs/gprs_ns.h</span><br><span>+++ b/include/osmocom/gprs/gprs_ns.h</span><br><span>@@ -226,4 +226,6 @@</span><br><span> </span><br><span> void gprs_ns_set_log_ss(int ss);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+char *gprs_nsvc_state_append(char *s, struct gprs_nsvc *nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! @} */</span><br><span>diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c</span><br><span>index 47d170d..75c3141 100644</span><br><span>--- a/src/gb/gprs_ns.c</span><br><span>+++ b/src/gb/gprs_ns.c</span><br><span>@@ -1705,4 +1705,26 @@</span><br><span>     DNS = ss;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Append the nsvc state to a talloc string</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param s The string to append to (allocated with talloc)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] nsvc The NS-VC to print the state of</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns The new string with state information appended to it</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This function will append a comma-separated state of the NS-VC to the</span><br><span style="color: hsl(120, 100%, 40%);">+ * string. The string needs to be allocated with talloc (e.g. talloc_strdup)</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+char *gprs_nsvc_state_append(char *s, struct gprs_nsvc *nsvc)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        s = talloc_asprintf_append(s,</span><br><span style="color: hsl(120, 100%, 40%);">+         "%u,%u,%s,%s,%s,%s,%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           nsvc->nsei, nsvc->nsvci,</span><br><span style="color: hsl(120, 100%, 40%);">+                NS_DESC_A(nsvc->state),</span><br><span style="color: hsl(120, 100%, 40%);">+            NS_DESC_B(nsvc->state),</span><br><span style="color: hsl(120, 100%, 40%);">+            nsvc->remote_end_is_sgsn ? "SGSN" : "BSS",</span><br><span style="color: hsl(120, 100%, 40%);">+             NS_DESC_A(nsvc->remote_state),</span><br><span style="color: hsl(120, 100%, 40%);">+             NS_DESC_B(nsvc->remote_state));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  return s;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! @} */</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 83a3621..d56e651 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -70,6 +70,7 @@</span><br><span> gprs_nsvc_reset;</span><br><span> gprs_nsvc_by_nsvci;</span><br><span> gprs_nsvc_by_nsei;</span><br><span style="color: hsl(120, 100%, 40%);">+gprs_nsvc_state_append;</span><br><span> </span><br><span> gprs_log_filter_fn;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9631">change 9631</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9631"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7f0eaff7329ab98cad792d30b20ab053007aab85 </div>
<div style="display:none"> Gerrit-Change-Number: 9631 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>