<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9603">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LMSDevice: Call LMS_Init() before setting sample rate<br><br>LMS_Init() will override basically all device settings with their<br>default value, including the sample rate.  We hence have to make sure<br>to call it before any other API function that changes the device config<br>such as sample rate, frequency, filter bandwidth, ...<br><br>Change-Id: I4cdbae8406b5e1e93da491e90f8bad41d4be748b<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/03/9603/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index 603b23d..0442e27 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -112,6 +112,12 @@</span><br><span> </span><br><span>      delete [] info_list;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      LOG(INFO) << "Init LMS device";</span><br><span style="color: hsl(120, 100%, 40%);">+       if (LMS_Init(m_lms_dev) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOG(ERROR) << "LMS_Init() failed";</span><br><span style="color: hsl(120, 100%, 40%);">+            return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  LOG(DEBUG) << "Setting sample rate to " << GSMRATE*sps << " " << sps;</span><br><span>    if (LMS_SetSampleRate(m_lms_dev, GSMRATE*sps, 32) < 0)</span><br><span>            goto out_close;</span><br><span>@@ -139,10 +145,6 @@</span><br><span>               goto out_close;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOG(INFO) << "Init LMS device";</span><br><span style="color: hsl(0, 100%, 40%);">- if (LMS_Init(m_lms_dev) < 0)</span><br><span style="color: hsl(0, 100%, 40%);">-         goto out_close;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      /* Perform Rx and Tx calibration */</span><br><span>  for (i=0; i<chans; i++) {</span><br><span>                 LOG(INFO) << "Calibrating chan " << i;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9603">change 9603</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9603"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4cdbae8406b5e1e93da491e90f8bad41d4be748b </div>
<div style="display:none"> Gerrit-Change-Number: 9603 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>