<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9624">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: Fail in case of unsupported configuration<br><br>There might be some configuration that's not supported by osmo-bts-lms,<br>and we should reject that properly.<br><br>Change-Id: I6f82edce589030a4407f6150fb7e8abe6417c1f2<br>Closes: OS#3347<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/24/9624/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index 815a4c5..16585e6 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -625,5 +625,13 @@</span><br><span>                               const std::vector < std::string > &tx_paths,</span><br><span>                               const std::vector < std::string > &rx_paths)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (tx_sps != rx_sps) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOG(ERROR) << "LMS Requires tx_sps == rx_sps";</span><br><span style="color: hsl(120, 100%, 40%);">+                return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (lo_offset != 0.0) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOG(ERROR) << "LMS doesn't support lo_offset";</span><br><span style="color: hsl(120, 100%, 40%);">+            return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span>    return new LMSDevice(tx_sps, rx_sps, iface, chans, lo_offset, tx_paths, rx_paths);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9624">change 9624</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9624"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6f82edce589030a4407f6150fb7e8abe6417c1f2 </div>
<div style="display:none"> Gerrit-Change-Number: 9624 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>