<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9613">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: Check LPBFW to set is within supported range<br><br>As of LimeSuite 618fbb9c3188b36d75ad5785a97b8887dcc468f6, it seems 5e6<br>is within the returned range, but LMS_SetLPFBW fails anyway.<br><br>See for more information: https://github.com/myriadrf/LimeSuite/issues/184<br><br>Change-Id: I967e7da7c0e3e8138b76733ee4a0e6311d20b62e<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 26 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/9613/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index fb1b794..d9b5ba6 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -77,10 +77,18 @@</span><br><span> pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void print_range(const char* name, lms_range_t *range)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG(DEBUG) << name << ": Min=" << range->min << " Max=" << range->max</span><br><span style="color: hsl(120, 100%, 40%);">+ << " Step=" << range->step;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int LMSDevice::open(const std::string &args, int ref, bool swap_channels)</span><br><span> {</span><br><span> //lms_info_str_t dev_str;</span><br><span> lms_info_str_t* info_list;</span><br><span style="color: hsl(120, 100%, 40%);">+ lms_range_t range_lpfbw_rx, range_lpfbw_tx, range_sr;</span><br><span style="color: hsl(120, 100%, 40%);">+ float_type sr_host, sr_rf, lpfbw_rx, lpfbw_tx;</span><br><span> uint16_t dac_val;</span><br><span> unsigned int i, n;</span><br><span> int rc;</span><br><span>@@ -118,18 +126,18 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- lms_range_t range;</span><br><span style="color: hsl(0, 100%, 40%);">- if (LMS_GetSampleRateRange(m_lms_dev, LMS_CH_RX, &range))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (LMS_GetSampleRateRange(m_lms_dev, LMS_CH_RX, &range_sr))</span><br><span> goto out_close;</span><br><span style="color: hsl(0, 100%, 40%);">- LOG(DEBUG) << "Sample Rate: Min=" << range.min << " Max=" << range.max << " Step=" << range.step;</span><br><span style="color: hsl(120, 100%, 40%);">+ print_range("Sample Rate", &range_sr);</span><br><span> </span><br><span> LOG(DEBUG) << "Setting sample rate to " << GSMRATE*sps << " " << sps;</span><br><span> if (LMS_SetSampleRate(m_lms_dev, GSMRATE*sps, 32) < 0)</span><br><span> goto out_close;</span><br><span style="color: hsl(0, 100%, 40%);">- float_type sr_host, sr_rf;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (LMS_GetSampleRate(m_lms_dev, LMS_CH_RX, 0, &sr_host, &sr_rf))</span><br><span> goto out_close;</span><br><span> LOG(DEBUG) << "Sample Rate: Host=" << sr_host << " RF=" << sr_rf;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* FIXME: make this device/model dependent, like UHDDevice:dev_param_map! */</span><br><span> //ts_offset = static_cast<TIMESTAMP>(8.9e-5 * GSMRATE);</span><br><span> ts_offset = 0;</span><br><span>@@ -155,11 +163,23 @@</span><br><span> goto out_close;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (LMS_GetLPFBWRange(m_lms_dev, LMS_CH_RX, &range_lpfbw_rx))</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out_close;</span><br><span style="color: hsl(120, 100%, 40%);">+ print_range("LPFBWRange Rx", &range_lpfbw_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (LMS_GetLPFBWRange(m_lms_dev, LMS_CH_RX, &range_lpfbw_tx))</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out_close;</span><br><span style="color: hsl(120, 100%, 40%);">+ print_range("LPFBWRange Tx", &range_lpfbw_tx);</span><br><span style="color: hsl(120, 100%, 40%);">+ lpfbw_rx = OSMO_MIN(OSMO_MAX(1.4001e6, range_lpfbw_rx.min), range_lpfbw_rx.max);</span><br><span style="color: hsl(120, 100%, 40%);">+ lpfbw_tx = OSMO_MIN(OSMO_MAX(5.2e6, range_lpfbw_tx.min), range_lpfbw_tx.max);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG(DEBUG) << "LPFBW: Rx=" << lpfbw_rx << " Tx=" << lpfbw_tx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Perform Rx and Tx calibration */</span><br><span> for (i=0; i<chans; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LMS_SetLPFBW(m_lms_dev, LMS_CH_RX, i, 1.4001e6) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG(INFO) << "Setting LPFBW chan " << i;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (LMS_SetLPFBW(m_lms_dev, LMS_CH_RX, i, lpfbw_rx) < 0)</span><br><span> goto out_close;</span><br><span style="color: hsl(0, 100%, 40%);">- if (LMS_SetLPFBW(m_lms_dev, LMS_CH_TX, i, 5.2e6) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (LMS_SetLPFBW(m_lms_dev, LMS_CH_TX, i, lpfbw_tx) < 0)</span><br><span> goto out_close;</span><br><span> LOG(INFO) << "Calibrating chan " << i;</span><br><span> if (LMS_Calibrate(m_lms_dev, LMS_CH_RX, i, LMS_CALIBRATE_BW_HZ, 0) < 0)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9613">change 9613</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9613"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I967e7da7c0e3e8138b76733ee4a0e6311d20b62e </div>
<div style="display:none"> Gerrit-Change-Number: 9613 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>