<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9539">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear()<br><br>While osmo-bsc was still affected of OS#3331, it would release the SCCP<br>connection from the BSC side.  This is illegal as per 3GPP spec and<br>has meanwhile been fixed in osmo-bsc master.  However, the testcase<br>BSC_Tests_LCLS.TC_lcls_connect_clear() relied on the broken behavior,<br>let's fix that.<br><br>The testcase now releases the SCCP connection from the simulated MSC<br>side in response to the BSSMAP Clear Complete from the BSC.<br><br>Change-Id: Ic3e1f8729a093b04941ec7ca72664d53adb21229<br>---<br>M bsc/BSC_Tests_LCLS.ttcn<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/9539/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>index fd37b4b..b99ba58 100644</span><br><span>--- a/bsc/BSC_Tests_LCLS.ttcn</span><br><span>+++ b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>@@ -116,6 +116,7 @@</span><br><span>     [] RSL.receive(RSL_Message:?) -> value rsl_msg { MASTER.send(rsl_msg); }</span><br><span>  /* from master process to ConnHdlr */</span><br><span>        [] MASTER.receive(PDU_BSSAP:?) -> value bssap { BSSAP.send(bssap); }</span><br><span style="color: hsl(120, 100%, 40%);">+       [] MASTER.receive(BSSAP_Conn_Prim:?) -> value bssap_p { BSSAP.send(bssap_p); }</span><br><span>    [] MASTER.receive(PDU_DTAP_MO:?) -> value dtap_mo { BSSAP.send(dtap_mo); }</span><br><span>        [] MASTER.receive(PDU_DTAP_MT:?) -> value dtap_mt { BSSAP.send(dtap_mt); }</span><br><span>        [] MASTER.receive(MgcpCommand:?) -> value mgcp_cmd { MGCP.send(mgcp_cmd); }</span><br><span>@@ -553,8 +554,9 @@</span><br><span>                 f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb);</span><br><span>             CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] CONN_A.receive(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_IND);</span><br><span style="color: hsl(0, 100%, 40%);">-      [] CONN_A.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(120, 100%, 40%);">+   [] CONN_A.receive(tr_BSSMAP_ClearComplete) {</span><br><span style="color: hsl(120, 100%, 40%);">+          CONN_A.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>    [] CONN_B.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_possible_ls));</span><br><span>  }</span><br><span>    f_sleep(2.0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9539">change 9539</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9539"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic3e1f8729a093b04941ec7ca72664d53adb21229 </div>
<div style="display:none"> Gerrit-Change-Number: 9539 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>