<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9538">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_subscr_conn_fsm: BSC must not release SCCP connection<br><br>3GPP TS 48.006 section 9.2 states clearly that any SCCP connection<br>release must be initiated by the MSC.<br><br>for bsc_subscr_conn_fsm, this means that even after sending the<br>BSSMAP CLEAR COMPLETE, we must not terminate the FSM, as this would<br>cause a N-DISCONNET.req to be sent to the stack for the associated<br>SCCP connection.<br><br>The bsc_subscr_conn_fsm instances will hence stay alive until the MSC<br>eventually decises to release them.<br><br>Change-Id: Iaaca220b598609b77b600fcfc2f9a78b221c1fbb<br>Closes: OS#3331<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/9538/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index bd652f0..4f09ae6 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -729,7 +729,9 @@</span><br><span>   case GSCON_EV_RSL_CLEAR_COMPL:</span><br><span>               resp = gsm0808_create_clear_complete();</span><br><span>              sigtran_send(conn, resp, fi);</span><br><span style="color: hsl(0, 100%, 40%);">-           osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, data);</span><br><span style="color: hsl(120, 100%, 40%);">+          /* we cannot terminate the FSM here, as that would send N-DISCCONNET.req</span><br><span style="color: hsl(120, 100%, 40%);">+               * and 3GPP TS 48.006 Section 9.2 clearly states that SCCP connections must</span><br><span style="color: hsl(120, 100%, 40%);">+            * always be released from the MSC side*/</span><br><span>            break;</span><br><span>       default:</span><br><span>             OSMO_ASSERT(false);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9538">change 9538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iaaca220b598609b77b600fcfc2f9a78b221c1fbb </div>
<div style="display:none"> Gerrit-Change-Number: 9538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>