<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9281">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assignment: signal assignment failure on chan act nack<br><br>When the BTS responds with a Chan Act NACK, i.e. the lchan could not be<br>activated, immediately signal Assignment Failure to the MSC (in<br>handle_chan_nack()).<br><br>In handle_chan_nack(), adjust log: instead of waiting for timeout, we now<br>signal Assignment Failure.<br><br>Drop misleading logging from bsc_assign_fail(): instead of transmitting the<br>Assignment Failure message, it actually signals an FSM event. Leave logging of<br>that to the FSM logging.<br><br>Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270<br>---<br>M src/osmo-bsc/bsc_api.c<br>M src/osmo-bsc/osmo_bsc_api.c<br>2 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_api.c b/src/osmo-bsc/bsc_api.c</span><br><span>index 02a59cc..7aa0e36 100644</span><br><span>--- a/src/osmo-bsc/bsc_api.c</span><br><span>+++ b/src/osmo-bsc/bsc_api.c</span><br><span>@@ -740,9 +740,10 @@</span><br><span>      if (conn->secondary_lchan != lchan)</span><br><span>               return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     LOGPLCHAN(lchan, DMSC, LOGL_ERROR, "Channel activation failed. Waiting for timeout now\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLCHAN(lchan, DMSC, LOGL_ERROR, "Channel activation failed.\n");</span><br><span>        conn->secondary_lchan->conn = NULL;</span><br><span>    conn->secondary_lchan = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+      bsc_assign_fail(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, NULL);</span><br><span> }</span><br><span> </span><br><span> static __attribute__((constructor)) void on_dso_load_bsc(void)</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_api.c b/src/osmo-bsc/osmo_bsc_api.c</span><br><span>index 51fbdd3..f3c36c3 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_api.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_api.c</span><br><span>@@ -425,8 +425,9 @@</span><br><span> /*! BSC->MSC: Assignment of lchan failed. */</span><br><span> void bsc_assign_fail(struct gsm_subscriber_connection *conn, uint8_t cause, uint8_t *rr_cause)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DMSC, LOGL_INFO, "Tx MSC ASSIGN FAIL\n");</span><br><span style="color: hsl(0, 100%, 40%);">-        osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+      LOGPFSML(conn->fi, LOGL_ERROR, "Assignment failure: BSSMAP: '%s' from RR: '%s'\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                gsm0808_cause_name(cause), rr_cause ? rr_cause_name(*rr_cause) : "(none)");</span><br><span style="color: hsl(120, 100%, 40%);">+        osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, &cause);</span><br><span> }</span><br><span> </span><br><span> /*! BSC->MSC: RR conn has been cleared. */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9281">change 9281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9281"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270 </div>
<div style="display:none"> Gerrit-Change-Number: 9281 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>