<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9514">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">compact AGCH queue: Drop too msg diff than IMM_ASS_REJ<br><br>We saw in a recent prod setup a BSC with saturated channels. Further<br>investigation lead to a AGCH queue of 1000 (previous hard_limit)<br>messages, most of them being regular IMM ASSIGN (non REJ). Hence, we<br>also want to get rid of other messages in the AGCH queue (like regular<br>IMM ASSIGN).<br><br>Furthermore, In this scenario, sending IMM ASS REJ is as important as other<br>messages given than nowadays we support dynamic wait indicatior<br>(calculated based on chan load), which means if we reach the MS, we can<br>tell it to wait for a long time to reach us again, which is desirable.<br><br>Change-Id: I022b8948da8be13fb8f4bc36e7c9dab11c35fddb<br>---<br>M src/common/bts.c<br>M tests/agch/agch_test.ok<br>2 files changed, 1 insertion(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/bts.c b/src/common/bts.c</span><br><span>index 4fa916c..ae75b2c 100644</span><br><span>--- a/src/common/bts.c</span><br><span>+++ b/src/common/bts.c</span><br><span>@@ -615,11 +615,6 @@</span><br><span> struct gsm48_imm_ass *imm_ass_cmd = msgb_l3(msg);</span><br><span> int p_drop;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (imm_ass_cmd->msg_type != GSM48_MT_RR_IMM_ASS_REJ)</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* IMMEDIATE ASSIGN REJECT */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> p_drop = (bts->agch_queue.length - offs) * slope / max_len;</span><br><span> </span><br><span> if ((random() & 0xffff) >= p_drop)</span><br><span>diff --git a/tests/agch/agch_test.ok b/tests/agch/agch_test.ok</span><br><span>index 4e0a9e1..a506f45 100644</span><br><span>--- a/tests/agch/agch_test.ok</span><br><span>+++ b/tests/agch/agch_test.ok</span><br><span>@@ -19,5 +19,5 @@</span><br><span> 50 28 14 28 28 28</span><br><span> Testing AGCH messages queue handling.</span><br><span> AGCH filled: count 720, imm.ass 80, imm.ass.rej 640 (refs 640), queue limit 32, occupied 101, dropped 0, merged 198, rejected 421, ag-res 0, non-res 0</span><br><span style="color: hsl(0, 100%, 40%);">-AGCH drained: multiframes 16, imm.ass 34, imm.ass.rej 12 (refs 42), queue limit 32, occupied 0, dropped 56, merged 198, rejected 421, ag-res 15, non-res 30</span><br><span style="color: hsl(120, 100%, 40%);">+AGCH drained: multiframes 4, imm.ass 2, imm.ass.rej 8 (refs 26), queue limit 32, occupied 0, dropped 92, merged 198, rejected 421, ag-res 3, non-res 6</span><br><span> Success</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9514">change 9514</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9514"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I022b8948da8be13fb8f4bc36e7c9dab11c35fddb </div>
<div style="display:none"> Gerrit-Change-Number: 9514 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>