<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9286">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: bsc_subscr_alloc: log initial get<br><br>Instead of silently setting the use count to 1, instead increment with an<br>explicit bsc_subsct_get(), which then logs the event along with the place that<br>created the subscriber.<br><br>Change-Id: Ia72f8010b7b2e1ca44e3b005c0f2c05f3eeae8d5<br>---<br>M src/osmo-bsc/bsc_subscriber.c<br>M tests/subscr/bsc_subscr_test.err<br>2 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c</span><br><span>index d9d90ba..65a660b 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscriber.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscriber.c</span><br><span>@@ -41,7 +41,6 @@</span><br><span>          return NULL;</span><br><span> </span><br><span>     llist_add_tail(&bsub->entry, list);</span><br><span style="color: hsl(0, 100%, 40%);">-      bsub->use_count = 1;</span><br><span> </span><br><span>  return bsub;</span><br><span> }</span><br><span>@@ -92,7 +91,7 @@</span><br><span>                return bsub;</span><br><span>         bsub = bsc_subscr_alloc(list);</span><br><span>       bsc_subscr_set_imsi(bsub, imsi);</span><br><span style="color: hsl(0, 100%, 40%);">-        return bsub;</span><br><span style="color: hsl(120, 100%, 40%);">+  return bsc_subscr_get(bsub);</span><br><span> }</span><br><span> </span><br><span> struct bsc_subscr *bsc_subscr_find_or_create_by_tmsi(struct llist_head *list,</span><br><span>@@ -104,7 +103,7 @@</span><br><span>                 return bsub;</span><br><span>         bsub = bsc_subscr_alloc(list);</span><br><span>       bsub->tmsi = tmsi;</span><br><span style="color: hsl(0, 100%, 40%);">-   return bsub;</span><br><span style="color: hsl(120, 100%, 40%);">+  return bsc_subscr_get(bsub);</span><br><span> }</span><br><span> </span><br><span> const char *bsc_subscr_name(struct bsc_subscr *bsub)</span><br><span>diff --git a/tests/subscr/bsc_subscr_test.err b/tests/subscr/bsc_subscr_test.err</span><br><span>index a66317a..afc8bf7 100644</span><br><span>--- a/tests/subscr/bsc_subscr_test.err</span><br><span>+++ b/tests/subscr/bsc_subscr_test.err</span><br><span>@@ -1,5 +1,8 @@</span><br><span style="color: hsl(120, 100%, 40%);">+DREF BSC subscr IMSI:1234567890 usage increases to: 1</span><br><span> DREF BSC subscr IMSI:1234567890 usage increases to: 2</span><br><span> DREF BSC subscr IMSI:1234567890 usage decreases to: 1</span><br><span style="color: hsl(120, 100%, 40%);">+DREF BSC subscr IMSI:9876543210 usage increases to: 1</span><br><span style="color: hsl(120, 100%, 40%);">+DREF BSC subscr IMSI:5656565656 usage increases to: 1</span><br><span> DREF BSC subscr IMSI:1234567890 usage increases to: 2</span><br><span> DREF BSC subscr IMSI:1234567890 usage decreases to: 1</span><br><span> DREF BSC subscr IMSI:9876543210 usage increases to: 2</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9286">change 9286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia72f8010b7b2e1ca44e3b005c0f2c05f3eeae8d5 </div>
<div style="display:none"> Gerrit-Change-Number: 9286 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>