<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9497">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">increment 'paging responded' counter for active paging only<br><br>Only count paging responses which can be mapped to an active paging.<br><br>Unsolicited paging responses which do not correspond to an active paging<br>would increment the 'paging response' counter. This means the number of<br>paging attempts could be smaller than the number of paging responses,<br>which can look confusing in the 'show statistics' VTY command.<br><br>Change-Id: I7cfc7c29fb7570d41e3ac23cca17f5b98b303506<br>Related: OS#66<br>---<br>M src/libbsc/paging.c<br>1 file changed, 12 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/9497/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libbsc/paging.c b/src/libbsc/paging.c</span><br><span>index cdcae51..d6bff2a 100644</span><br><span>--- a/src/libbsc/paging.c</span><br><span>+++ b/src/libbsc/paging.c</span><br><span>@@ -352,11 +352,12 @@</span><br><span>  * \param[in] bts BTS on which we shall stop paging</span><br><span>  * \param[in] bsub subscriber which we shall stop paging</span><br><span>  * \param[in] conn connection to the subscriber (if any)</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] msg message received from subscrbier (if any) */</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] msg message received from subscrbier (if any)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns 0 if an active paging request was stopped, an error code otherwise. */</span><br><span> /* we consciously ignore the type of the request here */</span><br><span style="color: hsl(0, 100%, 40%);">-static void _paging_request_stop(struct gsm_bts *bts, struct bsc_subscr *bsub,</span><br><span style="color: hsl(0, 100%, 40%);">-                               struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 struct msgb *msg)</span><br><span style="color: hsl(120, 100%, 40%);">+static int _paging_request_stop(struct gsm_bts *bts, struct bsc_subscr *bsub,</span><br><span style="color: hsl(120, 100%, 40%);">+                             struct gsm_subscriber_connection *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+                               struct msgb *msg)</span><br><span> {</span><br><span>       struct gsm_bts_paging_state *bts_entry = &bts->paging;</span><br><span>        struct gsm_paging_request *req, *req2;</span><br><span>@@ -370,9 +371,11 @@</span><br><span>                        paging_remove_request(&bts->paging, req);</span><br><span>                     LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Stop paging %s\n", bts->nr,</span><br><span>                         bsc_subscr_name(bsub));</span><br><span style="color: hsl(0, 100%, 40%);">-                    break;</span><br><span style="color: hsl(120, 100%, 40%);">+                        return 0;</span><br><span>            }</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   return -ENOENT;</span><br><span> }</span><br><span> </span><br><span> /*! Stop paging on all other bts'</span><br><span>@@ -391,9 +394,10 @@</span><br><span> </span><br><span>         /* Stop this first and dispatch the request */</span><br><span>       if (_bts) {</span><br><span style="color: hsl(0, 100%, 40%);">-             _paging_request_stop(_bts, bsub, conn, msg);</span><br><span style="color: hsl(0, 100%, 40%);">-            rate_ctr_inc(&_bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(0, 100%, 40%);">-         rate_ctr_inc(&_bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+           if (_paging_request_stop(_bts, bsub, conn, msg) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       rate_ctr_inc(&_bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+                       rate_ctr_inc(&_bts->network->bsc_ctrs->ctr[BSC_CTR_PAGING_RESPONDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>    }</span><br><span> </span><br><span>        /* Make sure to cancel this everywhere else */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9497">change 9497</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9497"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7cfc7c29fb7570d41e3ac23cca17f5b98b303506 </div>
<div style="display:none"> Gerrit-Change-Number: 9497 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>